Check sandwich dimensions #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanmart
requested review from
MarcAntoineSchmidtQC,
xhochy,
jtilly and
lbittarello
as code owners
MarcAntoineSchmidtQC
approved these changes
Sep 20, 2024
|
Can you add a quick changelog entry? I think it's helpful to track when a previous misuse of a method now raises an error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGELOG.rstentryAdd checks to raise an informative error on dimension or dtype mismatch in
MatrixBase.sandwich. Before this, a dimension mismatch led to eithernp.nans or simpoly wrong output depending on the platform.