-
-
Notifications
You must be signed in to change notification settings - Fork 30
feat(mound): add contract articles import functionality #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We need sonic to expose path of FileSupply to prevent manually concat
-->
|
Can you please update the PR to include the merged version? |
I've made some updates to the import logic to ensure a complete import of data related to articles and the pile, as the previous version wasn't quite cutting it. Could you please take a look and let me know if it aligns with the RGB design? And let me know if you spot anything that needs correcting. Here are the changes in this version:
Thanks so much for your time and expertise! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to import articles from an existing contract?
The only case when we need articles is where we issue new contracts (tokens). The issuer MUST not trust to other issuers and must pick an issuer object signed by some developer - not from other contract via articles.
Articles is not something which can be separated from a contract. I do not get why we need to import them in the first place...
This PR introduces a new
import_articles
function to theDirMound
implementation, allowing for the import of contract articles from external files.