Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mound): add purge contract functionality and error handling #302

Open
wants to merge 3 commits into
base: v0.12
Choose a base branch
from

Conversation

astral-bitlight
Copy link

No description provided.

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please:

  1. add to Mound outside of fs feature gate method named remove_contract moving the main logic there (without removing the directory)
  2. change the existing method purge_contract to call that remove_contract and then remove the dir. The flag keep_files will become unnecessary.

@astral-bitlight
Copy link
Author

I've moved the core contract removal logic to remove_contract in the main Mound impl per your request. Kindly review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants