feat(mound): Add export and import functions for Mound and FilePile #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-orlovsky
reviewed
Mar 25, 2025
| Ok(()) | ||
| } | ||
|
|
||
| pub fn strict_encode<W: WriteRaw>(&self, writer: &mut StrictWriter<W>) -> io::Result<()> { |
There was a problem hiding this comment.
It's better to avoid naming functions the same way as the trait methods. As an alternative, try to either derive StrictEncode/Decode directly on FilePile - or manually. You may also consider implementing StrictSerialize/Deserialize - in this case you won't need encode/decode_file above
There was a problem hiding this comment.
Okay, to avoid manual encoding, I've decided to derive these macros as you suggested. Here's a prerequisite PR (AluVM/sonic#12) that adds encode/decode support to Aura.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[THIS IS A DRAFT, TO BE DONE...]