drivers/include/.../rtt: Warn default RTT_MIN_OFFSET - #22617
Open
kfessel wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
Area: build system
kfessel
marked this pull request as ready for review
August 24, 2026 20:52
This was referenced Aug 24, 2026
crasbe
added
Type: enhancement
crasbe
reviewed
Aug 25, 2026
| @@ -319,7 +319,7 @@ endif | |||
| # Fail on warnings. Can be overridden by `make WERROR=0`. | |||
Contributor
There was a problem hiding this comment.
I think you should add to this comment that we fail on warnings, but not on #warnings (which is a bit confusing perhaps).
Contributor
Author
There was a problem hiding this comment.
Suggested change
| # Fail on warnings. Can be overridden by `make WERROR=0`. | |
| # Fail on compiler and linker warnings do not fail on preprocessor `#warning` . Can be overridden by `make WERROR=0`. |
Co-authored-by: Karl Fessel <karl.fessel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
show a warning if RTT_MIN_OFFSET default is applied due to missing configuratioon for mcu in use
Testing procedure
read
Issues/PRs references
#22600
Was introduced in #14259 but still has not much users
Declaration of AI-Tools / LLMs usage:
AI-Tools / LLMs that were used are: