pkg/bplib: Move Makefile out of patches - #22620
Merged
crasbe merged 1 commit intoAug 26, 2026
Merged
Conversation
crasbe
added
Type: enhancement
crasbe
reviewed
Aug 26, 2026
crasbe
left a comment
crasbe
left a comment
Contributor
There was a problem hiding this comment.
I checked on skyleaf and it still compiles with GCC and LLVM with the guarded CFLAGS.
Before, I placed the makefile compiling the library itself as a patch inside the bplib folder. For multiple reasons this is bad. The patch still remains and will be removed when I update the version of bplib.
RainbowSimon
force-pushed
the
bplib-buildsystem-improvements
branch
from
August 26, 2026 11:39
53010cc to
a3221e6
Compare
Contributor
Author
|
I am a little confused why this works now even though the package and module names are both bplib, but this caused some issues with decadriver |
crasbe
enabled auto-merge
August 26, 2026 11:55
RainbowSimon
added a commit
to RainbowSimon/RIOT
that referenced
this pull request
Aug 27, 2026
TODO: move all patches together into one commit, preferabbly before all other ones. Most of the patches of 7.0.2 remain and were cherry picked onto 7.0.5. The Makefile was removed due to PR RIOT-OS#22620.
RainbowSimon
added a commit
to RainbowSimon/RIOT
that referenced
this pull request
Aug 27, 2026
TODO: move all patches together into one commit, preferabbly before all other ones. Most of the patches of 7.0.2 remain and were cherry picked onto 7.0.5. The Makefile was removed due to PR RIOT-OS#22620.
RainbowSimon
added a commit
to RainbowSimon/RIOT
that referenced
this pull request
Aug 27, 2026
TODO: move all patches together into one commit, preferabbly before all other ones. Most of the patches of 7.0.2 remain and were cherry picked onto 7.0.5. The Makefile was removed due to PR RIOT-OS#22620.
RainbowSimon
added a commit
to RainbowSimon/RIOT
that referenced
this pull request
Aug 31, 2026
Most of the patches of 7.0.2 remain and were cherry picked onto 7.0.5. The Makefile patch was removed due to PR RIOT-OS#22620.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Before, I placed the makefile compiling the library itself as a patch inside the bplib folder. For multiple reasons this is bad.
Why this is better / Why was it bad before?
MODULE_DEFS_NEEDEDlist #22561 did not consider this case (rightfully so), now it can be easily added to the .include file.The patch still remains and will be removed when I update the version of bplib.
Currently the Makefiles contain all the includes/dependencies for all submodules (e.g. CLAs). When more such submodules are added I would also change this to use sub-Makefiles and include them, but for now this should still be fine.
Testing procedure
Since this is a buildsystem change it should be fine that it still compiles. It does and the
examples/networking/dtn/bplib_cla_udpstill works as expected on native.Issues/PRs references
Declaration of AI-Tools / LLMs usage:
AI-Tools / LLMs that were used are: