feat(benchmark): add MoE FP4 small-batch shapes and enable MoE by def…#332
Draft
zhiding512 wants to merge 2 commits intomainfrom
Draft
feat(benchmark): add MoE FP4 small-batch shapes and enable MoE by def…#332zhiding512 wants to merge 2 commits intomainfrom
zhiding512 wants to merge 2 commits intomainfrom
Conversation
…ault Signed-off-by: zhimding <zhimding@amd.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the benchmark runner to broaden MoE FP4 coverage (especially small-batch/token shapes) and to include MoE benchmarks in the default run set.
Changes:
- Add additional small-token MoE FP4 benchmark shapes.
- Add a larger-token MoE FP4 shape for the (7168, 2048) configuration.
- Enable MoE benchmarks by default in
run_benchmark.sh.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
208
to
+212
| RUN_SOFTMAX=1 | ||
| RUN_LAYERNORM=1 | ||
| RUN_RMSNORM=1 | ||
| RUN_PRESHUFFLE_GEMM=1 | ||
| RUN_MOE=0 | ||
| RUN_MOE=1 |
There was a problem hiding this comment.
The comment describing the default selected ops is now out of date: RUN_MOE is enabled by default, but the comment still says only softmax/norms/GEMM run unless the user enables others. Please update the comment so it matches the current default behavior (and/or adjust the wording around how to include/exclude MoE).
- Replace bytes_moved in stage1/stage2 with corrected formula: use aE=min(tokens*topk, experts) for weight bytes, proper scale group sizes (32 for FP4 MX, group_size for INT4, K for per-channel) - Skip MoE FP4 benchmark on non-gfx950 (e.g. MI325/gfx942) with 'Skipping FP4' message matched by run_benchmark.sh grep filter Signed-off-by: zhimding <zhimding@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.