Bump rocm-systems from `093b66c` to `96e30b4` by dependabot[bot] · Pull Request #3984 · ROCm/TheRock

dependabot · 2026-03-16T10:49:33Z

Bumps rocm-systems from 093b66c to 96e30b4.

Commits

96e30b4 call HIP_SKIP_TEST properly if device has no image support (#4040)
e1c229e SWDEV-581075 - Skip if managed memory not supported (#3598)
ce28e5f copy amd_icd_file to stage/etc/OpenCL/vendors (#3818)
55b57ee [ci] disabling mi325 test runners (#4062)
c873a9b [rocprofiler-compute][tui] Align TUI's analysis logic to GUI (#3641)
485f87f [rocprofiler-systems] Enable the roctx-api-runtime-instrument tests (#3990)
a8b23ed [TheRock CI] Fix workflow_dispatch project selection being overridden by CI f...
ceda961 [HSA][CLR][rocprofiler-sdk] hsa_amd_memory_async_batch_copy cherry-pick #3824...
d7d61f2 [rocdecode]users/rrawther/media libs test fix (#4056)
45365fb [rocprofiler-systems] Fix the ubuntu-jammy workflow (#4055)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rocm-systems](https://github.com/ROCm/rocm-systems) from `093b66c` to `96e30b4`. - [Release notes](https://github.com/ROCm/rocm-systems/releases) - [Commits](ROCm/rocm-systems@093b66c...96e30b4) --- updated-dependencies: - dependency-name: rocm-systems dependency-version: 96e30b429c074f8a3fcf66be9c014df4d7cbc681 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

chiranjeevipattigidi · 2026-03-16T14:22:20Z

It looks like the builds are still failing to apply the patch:
0003-Use-is_versioned-true-consistently-in-both-Comgr-Loa.patch
(Ref: https://github.com/ROCm/TheRock/blob/main/patches/amd-mainline/rocm-systems/0003-Use-is_versioned-true-consistently-in-both-Comgr-Loa.patch)
As mentioned earlier, @AmosLewis already shared some possible solutions in the previous PR discussion:
#3956 (comment)

ScottTodd · 2026-03-16T15:04:50Z

Docs for how to work with patch files: https://github.com/ROCm/TheRock/tree/main/patches#resolving-conflicts-with-patches

ScottTodd · 2026-03-16T15:06:41Z

The fix is to delete the patch. See ROCm/rocm-systems@b7167d0

geomin12

patches need to be fixed!

rocm-systems at 96e30b4 includes commit b7167d0 which sets kComgrVersioned = amd::IS_HIP (versioned for HIP, unversioned for OpenCL). Per patches/README.md: when the conflicting commit is equivalent to the patch, delete the patch. No longer apply this patch in TheRock CI. Made-with: Cursor

AmosLewis · 2026-03-17T00:20:56Z

Component	Classification	Error	Job Link	Filed Issues
hipsparse (Win gfx1151, 1/1 shard)	Code Failure	pre_checkin/bsrsv2.level2, csrsv2.level2 unit tests failed (f64_c, f32_c; block_dim 2/3/9/27/81)	gfx1151	Possible overlap rocm-libraries #5502
rocm[libraries,devel] wheels (Linux gfx1151)	Test/Packaging Bug	ROCmDevelTest.testSharedLibrariesLoad: ctypes.CDLL passed directory `etc/ld.so.conf.d` → OSError "Is a directory"	gfx1151	#3999
Windows gfx110X-all Build release	Infra	Self-hosted runner lost communication with server (~2h 20m)	job	—

Recommend: failures are pre-existing test/infra issues, not introduced by rocm-systems bump 093b66c→96e30b4 or patch delete. hipsparse pattern may overlap with rocm-libraries #5502. rocm-sdk test should skip directories in testSharedLibrariesLoad. Re-run only for infra (gfx110X) if needed; merge acceptable with known test failures tracked elsewhere. cc @geomin12

geomin12 · 2026-03-18T00:50:01Z

Re-based as we now have gfx94X runners to test on

dependabot · 2026-03-18T10:21:13Z

A newer version of rocm-systems exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

chiranjeevipattigidi · 2026-03-18T14:31:54Z

For rccl test failures, existing issue: #3774

amd-hsivasun · 2026-03-18T16:40:27Z

Reran tests as there appears to be some flaky tests. Namely rocfft, hipsparselt and rocgdb.

amd-aakash

Awaiting summary of known issues - lets merge this

ScottTodd · 2026-03-20T21:48:20Z

#3999 should really be fixed before we merge this. I don't see anyone actually working on it yet though. It should be a 1 line change to a python test file...

amd-hsivasun · 2026-03-20T22:13:05Z

#3999 should really be fixed before we merge this. I don't see anyone actually working on it yet though. It should be a 1 line change to a python test file...

The fix for this issue seems to have landed in 4 hours ago. We are starting another Bump PR cycle right after we merge this one.

amd-hsivasun · 2026-03-20T22:15:54Z

Summary for known issues

Issues with workarounds (while a full fix is pending)

Component	Issue	Notes
rocm-sdk test	#3999	PR #4015, Introduced some changes which need to be viewed in CI of this bump. See this comment #4015 (comment)
hipsparse	#5502	Repro was delayed while waiting for a system. In the meantime, workaround is expected to merge via #5605.
libhipcxx	TheRock#4031	Failure is not attributed to this bump; it showed up when MI300 machines were unavailable in an earlier nightly, likely tied to a compiler bump. Workaround direction: TheRock#4087.
rocprofiler-compute	TheRock#4034	Test may be flaky; guidance from dev is not to run this test.

Issues with no update

Component	Issue	Notes
RCCL	TheRock#3774	A fix was proposed in rocm-systems#3945 but it has remained unmerged for some time.

ScottTodd · 2026-03-20T22:23:25Z

#3999 should really be fixed before we merge this. I don't see anyone actually working on it yet though. It should be a 1 line change to a python test file...

The fix for this issue seems to have landed in 4 hours ago. We are starting another Bump PR cycle right after we merge this one.

No? As pointed out on that PR, it does not fix the issue. It is related, but there is still a bug in the python tests.

amd-hsivasun · 2026-03-20T22:33:14Z

#3999 should really be fixed before we merge this. I don't see anyone actually working on it yet though. It should be a 1 line change to a python test file...

The fix for this issue seems to have landed in 4 hours ago. We are starting another Bump PR cycle right after we merge this one.

No? As pointed out on that PR, it does not fix the issue. It is related, but there is still a bug in the python tests.

Sorry read through the PR but also saw "should also fix issue - #3999" in the PR description. Will hold off on Merging

amd-aakash

Lets address the changes mentioned by @ScottTodd - create a fresh Bump and merge that in after watching if we fix these issues.

ScottTodd · 2026-03-20T23:18:32Z

I suspect #4094 will fix #3999. We're testing now. I'd say we don't necessarily need to sync/rebase/restart this submodule update PR after that, we can just merge the PRs in sequence. It's a test at the leaf of the packages (but would affect users who pip install then run rocm-sdk test - that's why it matters to not let it break and rely on fixing afterwards).

ScottTodd

Approving the patch deletion for CODEOWNERS

The test failures in rocm-sdk test should be fixed now that #3999 is fixed (I tested with artifacts from this PR itself, see

I haven't personally been tracking the other issues spotted on this submodule update, so trusting others there.

Bumps [rocm-systems](https://github.com/ROCm/rocm-systems) from `093b66c` to `96e30b4`. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ROCm/rocm-systems/commit/96e30b429c074f8a3fcf66be9c014df4d7cbc681"><code>96e30b4</code></a> call HIP_SKIP_TEST properly if device has no image support (<a href="https://redirect.github.com/ROCm/rocm-systems/issues/4040">#4040</a>)</li> <li><a href="https://github.com/ROCm/rocm-systems/commit/e1c229e313e137b8b17d074d9b13bfa1697886b0"><code>e1c229e</code></a> SWDEV-581075 - Skip if managed memory not supported (<a href="https://redirect.github.com/ROCm/rocm-systems/issues/3598">#3598</a>)</li> <li><a href="https://github.com/ROCm/rocm-systems/commit/ce28e5fcce37b4e77f4e7e12d79b245905147e8e"><code>ce28e5f</code></a> copy amd_icd_file to stage/etc/OpenCL/vendors (<a href="https://redirect.github.com/ROCm/rocm-systems/issues/3818">#3818</a>)</li> <li><a href="https://github.com/ROCm/rocm-systems/commit/55b57eec37a7d128a5a760b93d28a0df084e11e7"><code>55b57ee</code></a> [ci] disabling mi325 test runners (<a href="https://redirect.github.com/ROCm/rocm-systems/issues/4062">#4062</a>)</li> <li><a href="https://github.com/ROCm/rocm-systems/commit/c873a9b2aabf64696f54dd1f47461f97aa23b09b"><code>c873a9b</code></a> [rocprofiler-compute][tui] Align TUI's analysis logic to GUI (<a href="https://redirect.github.com/ROCm/rocm-systems/issues/3641">#3641</a>)</li> <li><a href="https://github.com/ROCm/rocm-systems/commit/485f87f6bc0e2bcc822321d446b9298cc97dc845"><code>485f87f</code></a> [rocprofiler-systems] Enable the roctx-api-runtime-instrument tests (<a href="https://redirect.github.com/ROCm/rocm-systems/issues/3990">#3990</a>)</li> <li><a href="https://github.com/ROCm/rocm-systems/commit/a8b23edbe91e58655a19a0ab1e10ecd7be983b16"><code>a8b23ed</code></a> [TheRock CI] Fix workflow_dispatch project selection being overridden by CI f...</li> <li><a href="https://github.com/ROCm/rocm-systems/commit/ceda96122210ad48835ef6e5594497b0cdff5547"><code>ceda961</code></a> [HSA][CLR][rocprofiler-sdk] hsa_amd_memory_async_batch_copy cherry-pick <a href="https://redirect.github.com/ROCm/rocm-systems/issues/3824">#3824</a>...</li> <li><a href="https://github.com/ROCm/rocm-systems/commit/d7d61f29a44c3af7f5973a888d4da81b62242520"><code>d7d61f2</code></a> [rocdecode]users/rrawther/media libs test fix (<a href="https://redirect.github.com/ROCm/rocm-systems/issues/4056">#4056</a>)</li> <li><a href="https://github.com/ROCm/rocm-systems/commit/45365fb0fea22e64b83194e41c4e8a268e338e26"><code>45365fb</code></a> [rocprofiler-systems] Fix the ubuntu-jammy workflow (<a href="https://redirect.github.com/ROCm/rocm-systems/issues/4055">#4055</a>)</li> <li>Additional commits viewable in <a href="https://github.com/ROCm/rocm-systems/compare/093b66caa35ff225bb2846c8174c09f4ce62830c...96e30b429c074f8a3fcf66be9c014df4d7cbc681">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chi <chi.liu@amd.com> Co-authored-by: Geo Min <geomin12@amd.com> Co-authored-by: Aakash Sudhanwa <9801456+amd-aakash@users.noreply.github.com>

dependabot bot added dependencies Pull requests that update a dependency file submodules Pull requests that update submodules code labels Mar 16, 2026

dependabot bot requested a review from a team as a code owner March 16, 2026 10:49

dependabot bot added dependencies Pull requests that update a dependency file submodules Pull requests that update submodules code labels Mar 16, 2026

dependabot bot mentioned this pull request Mar 16, 2026

Bump rocm-systems from 093b66c to 077d0d5 #3956

Closed

geomin12 reviewed Mar 16, 2026

View reviewed changes

AmosLewis requested review from ScottTodd and marbre as code owners March 16, 2026 18:34

Merge branch 'main' into dependabot/submodules/main/rocm-systems-96e30b4

3bd110e

ScottTodd mentioned this pull request Mar 18, 2026

copy etc folder to artifacts ocl-lib #4015

Merged

1 task

This was referenced Mar 18, 2026

CI Failure: libcudacxx.test.lit – Complex Transcendental Functions Failures #4031

Closed

[Issue] rocprofiler-compute test_profile_pc_sampling Fails in CI Due to Unsupported PC Sampling on CI Agents #4034

Closed

Merge branch 'main' into dependabot/submodules/main/rocm-systems-96e30b4

374c1cb

amd-aakash approved these changes Mar 20, 2026

View reviewed changes

amd-aakash requested changes Mar 20, 2026

View reviewed changes

ScottTodd mentioned this pull request Mar 20, 2026

Filter directories from shared library glob results #4094

Merged

ScottTodd approved these changes Mar 20, 2026

View reviewed changes

amd-aakash approved these changes Mar 20, 2026

View reviewed changes

Merge branch 'main' into dependabot/submodules/main/rocm-systems-96e30b4

5c9e492

amd-hsivasun merged commit 62f313b into main Mar 21, 2026
160 of 182 checks passed

amd-hsivasun deleted the dependabot/submodules/main/rocm-systems-96e30b4 branch March 21, 2026 05:00

Conversation

dependabot bot commented on behalf of github Mar 16, 2026

Uh oh!

chiranjeevipattigidi commented Mar 16, 2026

Uh oh!

ScottTodd commented Mar 16, 2026

Uh oh!

ScottTodd commented Mar 16, 2026

Uh oh!

geomin12 left a comment

Choose a reason for hiding this comment

Uh oh!

AmosLewis commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geomin12 commented Mar 18, 2026

Uh oh!

dependabot bot commented on behalf of github Mar 18, 2026

Uh oh!

chiranjeevipattigidi commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amd-hsivasun commented Mar 18, 2026

Uh oh!

amd-aakash left a comment

Choose a reason for hiding this comment

Uh oh!

ScottTodd commented Mar 20, 2026

Uh oh!

amd-hsivasun commented Mar 20, 2026

Uh oh!

amd-hsivasun commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary for known issues

Issues with workarounds (while a full fix is pending)

Issues with no update

Uh oh!

ScottTodd commented Mar 20, 2026

Uh oh!

amd-hsivasun commented Mar 20, 2026

Uh oh!

amd-aakash left a comment

Choose a reason for hiding this comment

Uh oh!

ScottTodd commented Mar 20, 2026

Uh oh!

ScottTodd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

AmosLewis commented Mar 17, 2026 •

edited

Loading

chiranjeevipattigidi commented Mar 18, 2026 •

edited

Loading

amd-hsivasun commented Mar 20, 2026 •

edited

Loading