NVFP4 Random Hadamard Transform (butterfly permutation-based)#509
Open
matthiasdiener wants to merge 35 commits intodevfrom
Open
NVFP4 Random Hadamard Transform (butterfly permutation-based)#509matthiasdiener wants to merge 35 commits intodevfrom
matthiasdiener wants to merge 35 commits intodevfrom
Conversation
Remove TODO regarding userbuffers
Userbuffer Enablement for ROCm
matthiasdiener
changed the title
matthiasdiener
requested review from
ipanfilo,
wangye805 and
wenchenvincent
as code owners
* Update Dockerfile to use ROCm TheRock * Update wheels building script to work with ROCm TheRock and the latest Manylinux image * Support default ROCm location /opt/rocm/core * Fix UB code build on TheRock * Support comma separated list of target GPU architectures * Guess ROCm build from HIP_PLATFORM
UB MPI build hotfix
This was referenced Apr 2, 2026
Co-authored-by: Ye Wang <yewang12@amd.com>
ipanfilo
reviewed
Apr 3, 2026
|
|
||
| // Bit-cast __hip_bfloat16->uint16_t without address-of-temporary. | ||
| __device__ __forceinline__ uint16_t bf16_to_bits(__hip_bfloat16 v) { | ||
| uint16_t bits; __builtin_memcpy(&bits, &v, sizeof(uint16_t)); return bits; |
| #ifndef TRANSFORMER_ENGINE_HADAMARD_TRANSFORM_H_ | ||
| #define TRANSFORMER_ENGINE_HADAMARD_TRANSFORM_H_ | ||
|
|
||
| #ifndef __HIP_PLATFORM_AMD__ |
Collaborator
There was a problem hiding this comment.
Is it now identical to upstream variant?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements RHT via a butterfly permutation-based algorithm for NVFP4.
Has similar restrictions as upstream:
Fixes https://github.com/ROCm/frameworks-internal/issues/15732
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: