Add gfx1250 support: GFX_MAP + default GEMM/MHA configs#2282
Add gfx1250 support: GFX_MAP + default GEMM/MHA configs#2282
Conversation
Add GFX ID mapping for gfx1250 architecture.
There was a problem hiding this comment.
Pull request overview
Adds support for the gfx1250 GPU architecture by extending the GFX_MAP dictionary with a new entry.
Changes:
- Added
18: "gfx1250"to theGFX_MAPdictionary inchip_info.py, following the existing sequential ID assignment convention.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
sunway513
force-pushed
the
feat/gfx1250-support
branch
from
da71b90 to
b134a21
Compare
sunway513
changed the title
azaidy
left a comment
azaidy
left a comment
There was a problem hiding this comment.
I think we need assertion errors instead of fallbacks here. Fallbacks will make debug difficult. We can add default config files for all GEMMs and add an assertion to error out in case the default file doesnt exist.
Add 27 config files for gfx1250 (26 base GEMM + 1 MHA), copied from gfx950 as initial defaults. Only base configs are included — no N/K specialized tuning files, which will be added after running GemmTuner. This resolves KeyError/FileNotFoundError when running Triton GEMM and MHA kernels on gfx1250, without requiring code changes to the config loading logic. Verified on gfx1250: - test_gemm_a8w8_blockscale: 126 passed - test_batched_gemm_bf16: 196 passed - test_ff_a16w16: passing - test_mha: passing (including dropout/small head_dim cases)
sunway513
force-pushed
the
feat/gfx1250-support
branch
from
8e6df9c to
dfbcf93
Compare
sunway513
changed the title
|
@azaidy Updated per your feedback — replaced code fallback with 27 explicit config files (base GEMM + MHA, no N/K specializations). Zero code changes to config loading logic. Please re-review when you get a chance. |
Summary
18: "gfx1250") toGFX_MAPinchip_info.pyChanges
chip_info.py: Add18: "gfx1250"to GFX_MAPaiter/ops/triton/configs/:gemm/gfx1250-*.json(26 files) — base GEMM configs for all kernel typesgfx1250-MHA-DEFAULT.json— MHA attention configWhy configs instead of code fallback
Per review feedback: explicit config files are preferred over silent fallbacks to avoid masking debug issues. 27 base configs (vs 116 total with N/K specializations) provides functional coverage without bloat.
Verification on gfx1250
Test plan