Skip to content

BatchPD removal changes - updating snow API#439

Merged
LakshmiKumar23 merged 6 commits intoROCm:developfrom
SundarRajan28:snow_param_update
Feb 3, 2026
Merged

BatchPD removal changes - updating snow API#439
LakshmiKumar23 merged 6 commits intoROCm:developfrom
SundarRajan28:snow_param_update

Conversation

@SundarRajan98
Copy link
Contributor

@SundarRajan98 SundarRajan98 commented Dec 31, 2025

Motivation

This PR updates updates the vx_rpp version to 3.2.0 to match the batchPD removal PR in MIVISIONX. This PR also updates the snow augmentation API to match with the new snow tensor kernel.

Technical Details

This PR needs to be merged alongside the corresponding rpp PR and the MIVISIONX PR

Test Plan

Test Result

Submission Checklist

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the rocAL snow augmentation API to align with the new snow tensor kernel in RPP, adding support for brightness coefficient and dark mode parameters. The changes are part of the broader batchPD removal effort across the MIVisionX ecosystem.

  • Added two new parameters to the snow augmentation API: brightness_coefficient (range 1-4) and dark_mode (0/1)
  • Updated API signatures across C++, Python bindings, and test files to support the new parameters
  • Added version requirement check for MIVisionX vx_rpp

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
rocAL/CMakeLists.txt Adds version check for vx_rpp >= 3.1.2 to ensure compatibility with updated snow API
rocAL/include/augmentations/effects_augmentations/node_snow.h Adds brightness_coefficient and dark_mode member variables and updates init signatures
rocAL/include/api/rocal_api_augmentation.h Updates rocalSnow and rocalSnowFixed API signatures and documentation with new parameters
rocAL/source/augmentations/effects_augmentations/node_snow.cpp Implements initialization and handling of brightness_coefficient and dark_mode parameters
rocAL/source/api/rocal_api_augmentation.cpp Updates API implementation to pass new parameters to SnowNode
rocAL_pybind/amd/rocal/fn.py Adds brightness_coefficient and dark_mode parameters to Python snow function
tests/python_api/unit_test.py Updates Python test to use new snow parameters
tests/cpp_api/unit_tests/unit_tests.cpp Updates C++ test to use new snow parameters

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LakshmiKumar23 LakshmiKumar23 self-requested a review February 2, 2026 19:44
@LakshmiKumar23
Copy link
Contributor

/Azurepipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LakshmiKumar23 LakshmiKumar23 merged commit bd00370 into ROCm:develop Feb 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments