BatchPD removal changes - updating snow API#439
Merged
LakshmiKumar23 merged 6 commits intoROCm:developfrom Feb 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the rocAL snow augmentation API to align with the new snow tensor kernel in RPP, adding support for brightness coefficient and dark mode parameters. The changes are part of the broader batchPD removal effort across the MIVisionX ecosystem.
- Added two new parameters to the snow augmentation API:
brightness_coefficient(range 1-4) anddark_mode(0/1) - Updated API signatures across C++, Python bindings, and test files to support the new parameters
- Added version requirement check for MIVisionX vx_rpp
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| rocAL/CMakeLists.txt | Adds version check for vx_rpp >= 3.1.2 to ensure compatibility with updated snow API |
| rocAL/include/augmentations/effects_augmentations/node_snow.h | Adds brightness_coefficient and dark_mode member variables and updates init signatures |
| rocAL/include/api/rocal_api_augmentation.h | Updates rocalSnow and rocalSnowFixed API signatures and documentation with new parameters |
| rocAL/source/augmentations/effects_augmentations/node_snow.cpp | Implements initialization and handling of brightness_coefficient and dark_mode parameters |
| rocAL/source/api/rocal_api_augmentation.cpp | Updates API implementation to pass new parameters to SnowNode |
| rocAL_pybind/amd/rocal/fn.py | Adds brightness_coefficient and dark_mode parameters to Python snow function |
| tests/python_api/unit_test.py | Updates Python test to use new snow parameters |
| tests/cpp_api/unit_tests/unit_tests.cpp | Updates C++ test to use new snow parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
LakshmiKumar23
approved these changes
Feb 2, 2026
Contributor
|
/Azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR updates updates the vx_rpp version to 3.2.0 to match the batchPD removal PR in MIVISIONX. This PR also updates the snow augmentation API to match with the new snow tensor kernel.
Technical Details
This PR needs to be merged alongside the corresponding rpp PR and the MIVISIONX PR
Test Plan
Test Result
Submission Checklist