-
Notifications
You must be signed in to change notification settings - Fork 21
Add support for new augmentations in rocAL - Group 5 #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SundarRajan98
wants to merge
23
commits into
ROCm:develop
Choose a base branch
from
SundarRajan28:new_augs_set2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,024
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Spatter, Log, ColorJitter, Water - Add node headers and implementations for GaussianNoise, ShotNoise, Spatter, Log, ColorJitter, Water - Add C API declarations and implementations in rocal_api_augmentation.h/cpp - Add Python bindings in rocal_pybind.cpp and fn.py
…yscale, JpegCompressionDistortion, Lut, Posterize, Solarize - Add node headers and implementations for ChannelPermute, ColorToGreyscale, JpegCompressionDistortion, Lut, Posterize, Solarize - Add C API declarations and implementations in rocal_api_augmentation.h/cpp - Add Python bindings in rocal_pybind.cpp and fn.py
- Update VX_EXT_RPP_CHECK_VERSION to (3, 1, 6) in API file - Update THROW messages to indicate vx_rpp >= 3.1.6 - Add version checks in node files: node_channel_permute.cpp, node_color_to_greyscale.cpp, node_lut.cpp, node_posterize.cpp, node_solarize.cpp, node_jpeg_compression_distortion.cpp
- Update VX_EXT_RPP_CHECK_VERSION to (3, 1, 5) in API file - Update THROW messages to indicate vx_rpp >= 3.1.5 - Add version checks in node files: node_gaussian_noise.cpp, node_shot_noise.cpp, node_spatter.cpp, node_water.cpp, node_color_jitter.cpp, node_log.cpp
Test cases 74-83 for: - ChannelPermute (74) - JpegCompressionDistortion (75, 76-fixed) - LUT (77) - Posterize (78, 79-fixed) - Solarize (80, 81-fixed) - Log (82) - ColorToGreyscale (83)
C++ tests (unit_tests.cpp): - Case 64: rocalGaussianNoise (random) - Case 65: rocalGaussianNoiseFixed - Case 66: rocalShotNoise (random) - Case 67: rocalShotNoiseFixed - Case 68: rocalSpatter - Case 69: rocalLog - Case 70: rocalColorJitter (random) - Case 71: rocalColorJitterFixed - Case 72: rocalWater (random) - Case 73: rocalWaterFixed Python tests (unit_test.py): - gaussian_noise, shot_noise, spatter, water, color_jitter Shell scripts updated: - testAllScripts.sh: Added C++ test entries - unit_tests.sh: Added Python test entries
Shift test case numbers by +1 (75-83) to follow after Set 1 which now ends at case 74 due to added Spatter random variant.
Move version check to the very beginning of each function, before any variable assignments or context validation, for all Set 1 augmentation APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Integrates new RPP augmentations in rocAL:
Corresponding MIVisionX PR - #1602
Technical Details
Test Plan
Test Result
Submission Checklist