Fix issue with decoder example notebook #447
Open
+6
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SundarRajan98
requested review from
a team,
kiritigowda and
rrawther
as code owners
| " plt.imshow(img)\n", | ||
| " else:\n", | ||
| " plt.imshow(cp.asnumpy(img))\n", | ||
| " plt.imshow(img)\n", |
Contributor
There was a problem hiding this comment.
why was this changed? You still take device as input parameter to function on line 44
spolifroni-amd
approved these changes
Jan 22, 2026
Contributor
spolifroni-amd
left a comment
spolifroni-amd
left a comment
There was a problem hiding this comment.
Text looks fine. Docs approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes an issue with the decoder_examples.ipynb notebook in rocAL
Technical Details
Test Plan
Test Result
Submission Checklist