Fix logic error in dependencies_check: use variable depfile instead of hardcoded path#891
Open
THeF3r0 wants to merge 1 commit intoRPi-Distro:arm64from
Open
Fix logic error in dependencies_check: use variable depfile instead of hardcoded path#891THeF3r0 wants to merge 1 commit intoRPi-Distro:arm64from
THeF3r0 wants to merge 1 commit intoRPi-Distro:arm64from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix dependencies_check logic
The dependencies_check function iterates over the arguments ( $@ as$depfile ), but inside the loop, it was hardcoded to read $ {BASE_DIR}/depends. This prevented the function from checking any custom dependency files passed as arguments.
This PR changes the redirection to read from < "${depfile}" as intended.