-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add Cubox integration for saving entries #3385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your contribution. We will review it promptly. |
@LionChenA is attempting to deploy a commit to the RSS3 Team on Vercel. A member of the Team first needs to authorize it. |
Suggested PR Title:
Change Summary: Code Review: |
I see that Cubox has two APIs. Do you think adding an option to let users choose whether to save the web page or the content is necessary? |
Do you mean the url and memo types? Yes, I do notice the memo option. The memo type allows users to save a specific part of an article to Cubox, whereas the url type saves the full webpage. However, considering Folo’s mission of gathering resources from RSS and incorporating preprocessing workflows, I see memo as more aligned with fleeting notes or advanced processing, such as annotations, which can later be refined in Cubox or even more systematically in Zotero. Of course, this is just my perspective. Folo provides an environment for quickly browsing and filtering valuable articles. If an article proves valuable, I prefer saving it to Zotero to retain the full context. Since I don’t use Cubox in my daily workflow, I’d suggest letting users decide whether to add this option. Alternatively, I can implement it first and gather user feedback to see if it meets their needs. |
- Add Cubox integration with API token support - Add enableCuboxAutoMemo setting for auto memo mode - Add i18n translations for Cubox settings - Support saving selected text as memo when auto memo mode is enabled
I've added calls for both APIs. When the memo mode is enabled, clicking the save button will check whether any text is selected — if so, it uses the memo API; otherwise, it falls back to the url API. As for the SVG of Cubox, I’m currently in touch with their team. For now, it’s using the Eagle icon. Lastly, here’s a preview. |
Thank you for your contribution! 🎉 Your pull request has been merged and we really appreciate your help in making this project better. We hope to see more contributions from you in the future! 💪 |
close #1070 .
Added the feat on existing code, with i18n for English and Chinese.
Questions: