-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[riscv]统一plic和中断控制的接口实现 #10147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[riscv]统一plic和中断控制的接口实现 #10147
Conversation
1、plic_base的赋值:建议把plic_base 定义为全局变量,各bsp在rt_hw_board_init中对plic_base赋值,同时在plic_init中判断下该值是不是NULL; |
1:后续可能会支持从设备树读取基地址,所以暂时就保持用配置的方式,而且这个pr我也不想太多改动bsp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR integrates the PLIC component into the interrupt control interface for RISCV by updating the build scripts.
- Adds a new SConscript file for the plic component.
- Updates the main SConscript to include the plic SConscript file under the common64_arch condition.
Reviewed Changes
Copilot reviewed 2 out of 18 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
libcpu/risc-v/plic/SConscript | New build script for the plic component. |
libcpu/risc-v/SConscript | Updated to include the plic SConscript when building for common64 CPUs. |
Files not reviewed (16)
- bsp/qemu-virt64-riscv/driver/board.c: Language not supported
- libcpu/risc-v/common64/interrupt.c: Language not supported
- libcpu/risc-v/common64/interrupt.h: Language not supported
- libcpu/risc-v/plic/plic.c: Language not supported
- libcpu/risc-v/plic/plic.h: Language not supported
- libcpu/risc-v/t-head/c906/interrupt.c: Language not supported
- libcpu/risc-v/t-head/c906/interrupt.h: Language not supported
- libcpu/risc-v/t-head/c906/plic.c: Language not supported
- libcpu/risc-v/t-head/c906/plic.h: Language not supported
- libcpu/risc-v/t-head/c908/interrupt.c: Language not supported
- libcpu/risc-v/t-head/c908/interrupt.h: Language not supported
- libcpu/risc-v/t-head/c908/plic.c: Language not supported
- libcpu/risc-v/t-head/c908/plic.h: Language not supported
- libcpu/risc-v/virt64/interrupt.c: Language not supported
- libcpu/risc-v/virt64/plic.c: Language not supported
- libcpu/risc-v/virt64/plic.h: Language not supported
Comments suppressed due to low confidence (2)
libcpu/risc-v/plic/SConscript:11
- [nitpick] If this script is specific to the plic component, consider renaming the group from 'libcpu' to 'plic' for clearer organization.
group = DefineGroup('libcpu', src, depend = [''], CPPPATH = CPPPATH)
libcpu/risc-v/SConscript:16
- Verify that including the plic SConscript exclusively under the common64_arch condition is intentional; if support is required for other CPU types, adjust the condition accordingly.
group += SConscript(os.path.join('plic', 'SConscript'))
Co-authored-by: Copilot <[email protected]>
这个AI仅供参考,以实际使用为准。 |
ai推荐的这个改动在本地编译也没问题 |
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
k230 qemu
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up