-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[action/ci] 根据看护产品,结合版本versionconfig ci自动生成版本测试产物 #10170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
f618a06
to
db1e326
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- .github/PART_BSP_COMPILE.json: Language not supported
- bsp/stm32/stm32f407-rt-spark/.ci/SConscript: Language not supported
Comments suppressed due to low confidence (2)
tools/ci/bsp_buildings.py:299
- The variable 'count' is used without a clear prior initialization in this diff context; ensure that it is defined before this usage.
count += 1
bsp/stm32/stm32f407-rt-spark/board/SConscript:14
- The removal of the 'CPPDEFINES' parameter (previously set to ['STM32F407xx']) may affect conditional compilation; please verify that this change is intentional.
group = DefineGroup('Drivers', src, depend = [''], CPPPATH = path)
tools/ci/bsp_buildings.py
Outdated
config_bacakup = config_file+'.origin' | ||
shutil.copyfile(config_file, config_bacakup) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable name 'config_bacakup' appears to be misspelled; consider renaming it to 'config_backup' for clarity.
config_bacakup = config_file+'.origin' | |
shutil.copyfile(config_file, config_bacakup) | |
config_backup = config_file+'.origin' | |
shutil.copyfile(config_file, config_backup) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
if: ${{ matrix.legs.RTT_TOOL_CHAIN == 'sourcery-arm'}} | ||
id: cache-gcc-arm | ||
uses: actions/cache@main | ||
with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个建议复用当前的yml不用另外建,可以通过参数加载不同的json文件
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
修改为了如果bsp下包含了versionconfig.yml才编译
db1e326
to
20d24aa
Compare
dec8bbf
to
757baf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- bsp/stm32/stm32f407-rt-spark/.ci/SConscript: Language not supported
Comments suppressed due to low confidence (2)
bsp/stm32/stm32f407-rt-spark/board/SConscript:14
- Ensure the removal of CPPDEFINES is intentional, as preprocessor definitions like 'STM32F407xx' might be needed for proper compilation.
group = DefineGroup('Drivers', src, depend = [''], CPPPATH = path)
bsp/stm32/stm32f407-rt-spark/.ci/versionconfig/SConscript:10
- [nitpick] Consider renaming 'list' to avoid shadowing Python's built-in name, for example, use 'files_list' instead.
list = os.listdir(cwd)
output_contral: | ||
description: 'Output Contral' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Possible typo: consider renaming 'output_contral' to 'output_control' for clarity.
output_contral: | |
description: 'Output Contral' | |
output_control: | |
description: 'Output Control' |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
编写一份CI脚本,针对重点看护产品,结合版本versionconfig ci自动生成版本测试产物,其中包含针对不同平台下,不同驱动/外设/软件包生成的可执行文件
在原本的yml基础上,同时还会编译对应的的demo.c文件,举个例子,这个pr中包含一个aht21的例子,内容是上电后自动读取温湿度并打印出来,最后生成该demo的bin文件,可以直接烧写进板子里测试
你的解决方案是什么 (what is your solution)
attachconfig生成的产物:
https://github.com/hydevcode/rt-thread/actions/runs/14299438695
versionconfig生成的产物:
https://github.com/hydevcode/rt-thread/actions/runs/14299305688
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up