Skip to content

[action/ci] 根据看护产品,结合版本versionconfig ci自动生成版本测试产物 #10170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hydevcode
Copy link
Contributor

@hydevcode hydevcode commented Apr 3, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

编写一份CI脚本,针对重点看护产品,结合版本versionconfig ci自动生成版本测试产物,其中包含针对不同平台下,不同驱动/外设/软件包生成的可执行文件

在原本的yml基础上,同时还会编译对应的的demo.c文件,举个例子,这个pr中包含一个aht21的例子,内容是上电后自动读取温湿度并打印出来,最后生成该demo的bin文件,可以直接烧写进板子里测试

你的解决方案是什么 (what is your solution)

image

attachconfig生成的产物:

https://github.com/hydevcode/rt-thread/actions/runs/14299438695

versionconfig生成的产物:

https://github.com/hydevcode/rt-thread/actions/runs/14299305688

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP action github action yml imporve tools labels Apr 3, 2025
@hydevcode hydevcode marked this pull request as draft April 3, 2025 10:38
@supperthomas supperthomas requested a review from Copilot April 6, 2025 12:59
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • .github/PART_BSP_COMPILE.json: Language not supported
  • bsp/stm32/stm32f407-rt-spark/.ci/SConscript: Language not supported
Comments suppressed due to low confidence (2)

tools/ci/bsp_buildings.py:299

  • The variable 'count' is used without a clear prior initialization in this diff context; ensure that it is defined before this usage.
count += 1

bsp/stm32/stm32f407-rt-spark/board/SConscript:14

  • The removal of the 'CPPDEFINES' parameter (previously set to ['STM32F407xx']) may affect conditional compilation; please verify that this change is intentional.
group = DefineGroup('Drivers', src, depend = [''], CPPPATH = path)

Comment on lines 300 to 301
config_bacakup = config_file+'.origin'
shutil.copyfile(config_file, config_bacakup)
Copy link
Preview

Copilot AI Apr 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name 'config_bacakup' appears to be misspelled; consider renaming it to 'config_backup' for clarity.

Suggested change
config_bacakup = config_file+'.origin'
shutil.copyfile(config_file, config_bacakup)
config_backup = config_file+'.origin'
shutil.copyfile(config_file, config_backup)

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

if: ${{ matrix.legs.RTT_TOOL_CHAIN == 'sourcery-arm'}}
id: cache-gcc-arm
uses: actions/cache@main
with:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个建议复用当前的yml不用另外建,可以通过参数加载不同的json文件

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修改为了如果bsp下包含了versionconfig.yml才编译

@supperthomas supperthomas requested a review from Copilot April 7, 2025 02:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • bsp/stm32/stm32f407-rt-spark/.ci/SConscript: Language not supported
Comments suppressed due to low confidence (2)

bsp/stm32/stm32f407-rt-spark/board/SConscript:14

  • Ensure the removal of CPPDEFINES is intentional, as preprocessor definitions like 'STM32F407xx' might be needed for proper compilation.
group = DefineGroup('Drivers', src, depend = [''], CPPPATH = path)

bsp/stm32/stm32f407-rt-spark/.ci/versionconfig/SConscript:10

  • [nitpick] Consider renaming 'list' to avoid shadowing Python's built-in name, for example, use 'files_list' instead.
list = os.listdir(cwd)

Comment on lines +38 to +39
output_contral:
description: 'Output Contral'
Copy link
Preview

Copilot AI Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Possible typo: consider renaming 'output_contral' to 'output_control' for clarity.

Suggested change
output_contral:
description: 'Output Contral'
output_control:
description: 'Output Control'

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action github action yml imporve BSP: STM32 BSP related with ST/STM32 BSP tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants