fix ifx_pin_irq_enable #10231
Open
fix ifx_pin_irq_enable #10231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
修改中断号不正确问题
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an incorrect interrupt number computation in the ifx_pin_irq_enable function. It removes the unintentional addition of the port offset by eliminating the PORT_GET call in two places.
- Removed the unnecessary addition to the IRQ number.
- Updated both the initialization and de-initialization sections for consistent IRQ handling.
| @@ -320,7 +321,7 @@ static rt_err_t ifx_pin_irq_enable(struct rt_device *device, rt_base_t pin, | |||
| irqmap = &pin_irq_map[gpio_port]; | |||
|
|
|||
| #if !defined(COMPONENT_CAT1C) | |||
| IRQn_Type irqn = (IRQn_Type)(irqmap->irqno + PORT_GET(irqmap->port)); | |||
| IRQn_Type irqn = irqmap->irqno; | |||
| irq_cb_data[irqn].callback = irq_callback; | |||
| irq_cb_data[irqn].callback_arg = (rt_uint16_t *)&pin_irq_map[gpio_port].port; | |||
There was a problem hiding this comment.
Eliminating the addition of PORT_GET (irqmap->port) ensures that the correct IRQ number is used during IRQ initialization.
Suggested change
| irq_cb_data[irqn].callback_arg = (rt_uint16_t *)&pin_irq_map[gpio_port].port; | |
| irq_cb_data[irqn].callback_arg = (rt_uint16_t *)&irqmap->port; // Directly use irqmap->port |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <[email protected]>
|
标题改一下 |
supperthomas
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
修改ifx_pin_irq_enable中断号不正确问题
你的解决方案是什么 (what is your solution)
将IRQn_Type irqn = (IRQn_Type)(irqmap->irqno + PORT_GET(irqmap->port));改为IRQn_Type irqn = irqmap->irqno;
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up