Skip to content

Upgrade RISC-V ToolChains for bluetrum/ab32vg1-ab-prougen,qemu-virt64,ultrarisc/ur_dp1000_evb to gcc 12.x #10739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Upgrade RISC-V ToolChains for bluetrum/ab32vg1-ab-prougen,qemu-virt64,ultrarisc/ur_dp1000_evb to gcc 12.x #10739

wants to merge 3 commits into from
+240 −125

Conversation

@lygstate
Copy link
Contributor

@lygstate lygstate commented Sep 25, 2025

拉取/合并请求描述：(PR description)

There is no proper windows toolchain for risvc for gcc 10.0
upgrade 12.x we have same tool with linux.

rv64gc is equivalent to rv64imafdc_zicsr_zifencei in gcc 12.x

fixes warning: rtthread.elf has a LOAD segment with RWX permissions

This warning is present when compile with gcc 12.x:
c:/env-windows/tools/gnu_gcc/riscv64-linux-musleabi_for_i686-w64-mingw32/bin/../lib/gcc/riscv64-linux-musleabi/12.2.0/../../../../riscv64-linux-musleabi/bin/ld.exe: warning: rtthread.elf has a LOAD segment with RWX permissions

Add normal-env.bat and smart-env.bat for these bsp when needed

[

为什么提交这份PR (why to submit this PR)

There is no proper toolchain for riscv on windows

你的解决方案是什么 (what is your solution)

upgrade to gcc 12.x

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
    bluetrum/ab32vg1-ab-prougen,qemu-virt64,ultrarisc/ur_dp1000_evb
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions
Copy link

github-actions bot commented Sep 25, 2025 •
edited
Loading

📌 Code Review Assignment

🏷️ Tag: bsp_ultrarisc

Reviewers: zhangjing0303

Changed Files (Click to expand)
  • bsp/ultrarisc/ur_dp1000_evb/SConstruct
  • bsp/ultrarisc/ur_dp1000_evb/normal-env.bat
  • bsp/ultrarisc/ur_dp1000_evb/rtconfig.py
  • bsp/ultrarisc/ur_dp1000_evb/smart-env.bat

🏷️ Tag: workflow

Reviewers: Rbb666 kurisaW supperthomas

Changed Files (Click to expand)
  • .github/workflows/action_utest.yml
  • .github/workflows/bsp_buildings.yml
  • .github/workflows/manual_bsp_build.yml
  • .github/workflows/manual_dist.yml
  • .github/workflows/manual_trigger_scons_except_STM32_all.yml
  • .github/workflows/manual_trigger_scons_fail_bsp_all.yml
  • .github/workflows/manual_trigger_update_all.yml
  • .github/workflows/utest_auto_run.yml

📊 Current Review Status (Last Updated: 2025-09-27 07:53 CST)

  • ⌛ Rbb666 Pending Review
  • ⌛ kurisaW Pending Review
  • ⌛ supperthomas Pending Review
  • ⌛ zhangjing0303 Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions github-actions bot added BSP action github action yml imporve tools labels Sep 25, 2025
@github-actions
Copy link

github-actions bot commented Sep 25, 2025

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below.

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：upgrade-riscv-toolchain
  • 设置PR number为 \ Set the PR number to：10739
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 upgrade-riscv-toolchain 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the upgrade-riscv-toolchain branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@lygstate lygstate force-pushed the upgrade-riscv-toolchain branch from f40085b to 15e0e33 Compare September 25, 2025 01:06
@lygstate
Upgrade RISC-V ToolChains for bluetrum/ab32vg1-ab-prougen,qemu-virt64…
fa2d07e 
…-riscv,ultrarisc/ur_dp1000_evb to gcc 12.x

In total, rv64gc is equivalent to rv64imafdc_zicsr_zifencei.

fixes warning: rtthread.elf has a LOAD segment with RWX permissions

c:/env-windows/tools/gnu_gcc/riscv64-linux-musleabi_for_i686-w64-mingw32/bin/../lib/gcc/riscv64-linux-musleabi/12.2.0/../../../../riscv64-linux-musleabi/bin/ld.exe: warning: rtthread.elf has a LOAD segment with RWX permissions

Add normal-env.bat and smart-env.bat
@lygstate lygstate force-pushed the upgrade-riscv-toolchain branch from 15e0e33 to 57031e1 Compare September 26, 2025 23:28
@lygstate lygstate requested a review from kurisaW as a code owner September 26, 2025 23:28
@lygstate lygstate force-pushed the upgrade-riscv-toolchain branch from 57031e1 to 0108cfb Compare September 26, 2025 23:52
@kurisaW
Copy link
Member

kurisaW commented Oct 7, 2025

工具链更新建议从此处完成，不要直接使用上游仓库：https://github.com/RT-Thread/toolchains-ci/releases

BernardXiong
BernardXiong reviewed Oct 11, 2025
View reviewed changes
.github/workflows/action_utest.yml
shell: bash
run: |
wget -q https://github.com/RT-Thread/toolchains-ci/releases/download/v1.7/riscv64-linux-musleabi_for_x86_64-pc-linux-gnu_latest.tar.bz2
wget -q https://download.rt-thread.org/download/rt-smart/toolchains/riscv64-linux-musleabi_for_x86_64-pc-linux-gnu_latest.tar.bz2
Copy link
Member

@BernardXiong BernardXiong Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不建议使用 download.rt-thread.org 的工具链用于ci，特别还是latest版本的工具链。如果需要，可以更新 toolchains-ci 中的版本。

Copy link
Contributor Author

@lygstate lygstate Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toolchains-ci 如何升级？

@unicornx unicornx added the Arch: RISC-V BSP related with risc-v label Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BernardXiong BernardXiong BernardXiong left review comments

@supperthomas supperthomas Awaiting requested review from supperthomas supperthomas is a code owner

@kurisaW kurisaW Awaiting requested review from kurisaW kurisaW is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

action github action yml imporve Arch: RISC-V BSP related with risc-v BSP tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lygstate @kurisaW @BernardXiong @unicornx