Skip to content

COMP: Fix format string#960

Merged
SimonRit merged 1 commit into
RTKConsortium:mainfrom
axel-grc:Warnings
Jun 22, 2026
Merged

COMP: Fix format string#960
SimonRit merged 1 commit into
RTKConsortium:mainfrom
axel-grc:Warnings

Conversation

@axel-grc

Copy link
Copy Markdown
Collaborator

Replace the snprintf-based iteration output formatting with a direct substitution of the documented %d placeholder.

This avoids GCC's -Wformat-nonliteral warning when the filename pattern comes from --iteration-file-name, while preserving the supported behavior.

@SimonRit SimonRit left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. The failing CI is unrelated I believe.
When the minimum C++ standard wil be 20, we'll switch to using std::format.

@SimonRit SimonRit merged commit 0d66d91 into RTKConsortium:main Jun 22, 2026
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants