Skip to content

Conversation

@sp1ritCS
Copy link
Contributor

This changeset adds a new meson option to allow including the clapper gst plugin statically. Additionally, I've dropped the ability of loading importers dynamically altogether, as it was easier this way and I didn't see the point of it.

sp1ritCS added 2 commits June 30, 2025 14:26
I don't see the point of being able to load them dynamically.
When building with -Dbuiltin-loaders=true (default false, due to some
external components depending on it), the clapper gst plugin will be
built as static library and linked into libclapper-gtk.
@Rafostar
Copy link
Owner

Rafostar commented Jul 3, 2025

Hi. Thanks for PR.

I do agree, these "importer modules" should go away. Even more so now, since it looks like there are even bigger compatibility issues with GStreamer 1.26 (issue: #560).

But due to the above, I am not sure ATM whether to get this change in or just work on the new/next sink sooner and disable this "legacy" code by default (or maybe even drop it).

@sp1ritCS
Copy link
Contributor Author

sp1ritCS commented Jul 3, 2025

But due to the above, I am not sure ATM whether to get this change in or just work on the new/next sink sooner and disable this "legacy" code by default (or maybe even drop it).

I don't see why not. I'll assume that you'll have to keep the old sink around, as others (mainly hanabi) are depending on it, but those loader modules are basically internal to clapper in the first place and being able to dynamically load them doesn't really help anybody.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants