Add support for DBF file encoding #139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting scenario. Do you have data files I could test it with? Thanks for the PR. I only noticed it now. |
|
I'm unsure if it can be shared publicly. Do you have an email or similar I can send it to? |
|
Nice improvement @mloenow - can probably share publicly a small subset of your confidential data or make a synthetic example with Scandinavian characters. @RandomFractals approve to merge? |
|
@ts-ldash I don't have access to the data anymore, sorry. I still believe the change is correct. Some of the dependencies might have changed since, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Awesome extension — thanks for making it!
I had issues with some Scandinavian characters, which can be fixed by including the encoding as the second argument in the DBF parser. According to the spec[0] a
.cpgfile can specify the encoding, so this pull request adds support for that.[0] Well, Wikipedia (see Other files), as well as shapefile-js and parseDBF.