add support for clan/server tags #10190
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And also, this is undocumented in discord's side. |
DA-344
suggested changes
May 19, 2025
| def __init__(self, data: ClanTagPayload): | ||
| self.identity_guild_id: Optional[int] = (int(data["identity_guild_id"]) if data.get("identity_guild_id") is not None else None) | ||
| self.identity_enabled: bool = data.get("identity_enabled", False) | ||
| self.tag: Optional[str] = data.get("tag", "null") |
There was a problem hiding this comment.
This will not make this optional, just use data.get
| self.identity_guild_id: Optional[int] = (int(data["identity_guild_id"]) if data.get("identity_guild_id") is not None else None) | ||
| self.identity_enabled: bool = data.get("identity_enabled", False) | ||
| self.tag: Optional[str] = data.get("tag", "null") | ||
| self.badge: Optional[str] = data.get("badge", "null") |
There was a problem hiding this comment.
Same as mentioned on self.tag
Comment on lines
+26
to
+34
| from typing import TypedDict, Optional | ||
| from .types.snowflake import Snowflake | ||
|
|
||
|
|
||
| class ClanTagPayload(TypedDict): | ||
| identity_guild_id: Snowflake | ||
| identity_enabled: bool | ||
| tag: str | ||
| badge: str |
There was a problem hiding this comment.
All of this should be on its discord/types file, not here.
| __slots__ = ("identity_guild_id", "identity_enabled", "tag", "badge") | ||
|
|
||
| def __init__(self, data: ClanTagPayload): | ||
| self.identity_guild_id: Optional[int] = (int(data["identity_guild_id"]) if data.get("identity_guild_id") is not None else None) |
There was a problem hiding this comment.
Use utils._get_as_snowflake
| @@ -25,6 +25,7 @@ | |||
| from .snowflake import Snowflake | |||
| from typing import Literal, Optional, TypedDict | |||
| from typing_extensions import NotRequired | |||
| from ..clantag import ClanTagPayload | |||
There was a problem hiding this comment.
Same as mentioned on the TypedDict
| @@ -39,6 +40,8 @@ class PartialUser(TypedDict): | |||
| avatar: Optional[str] | |||
| global_name: Optional[str] | |||
| avatar_decoration_data: NotRequired[AvatarDecorationData] | |||
| clan: NotRequired[ClanTagPayload] | |||
There was a problem hiding this comment.
Clan is deprecated, as dolphies said
Comment on lines
+132
to
+133
| if clan_data: | ||
| self.clan_tag: Optional[ClanTag] = ClanTag(clan_data) |
There was a problem hiding this comment.
This will raise an attribute error if the clan data is None
Co-authored-by: DA344 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
adds support for clan/server tags
Checklist
i only bothered to add this bcuz i needed to use it in one of my bots and i was surprised that it hasnt been added yet
this is a super hacky fix and im honestly surprised i got it to work, but it would probably be a good idea to clean it up a bit
why did i spend 3 hours on this what am i doing with my life