Feat/card action restyled - #8
Merged
Merged
Conversation
A copy of onboarding-mentor/dashboard-primary-action with the confirm screen rebuilt. Copied rather than restyled in place, per the repo rule — the original belongs to someone else, and two treatments of one route only compare if both are still there to compare. Everything but the confirm screen is unchanged, including the cast, so a session can attribute a reaction to the presentation rather than the route. The confirm screen is now one centred card modelled on the Experience CS interstitial: the three points about Code Classroom are green panels with a Material Symbols icon instead of bullets, the copy is rewritten around "creators", and the primary action sits bottom right after the explanation rather than beside it. No illustration yet — what it should show has not been designed, and an invented one would get reacted to as though it had. The hypothesis in meta.ts is marked DRAFT for Sarah to confirm: that the confirm screen is where a mentor learns what Code Classroom is, and that a mentor who has read this version can say what they agreed to. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Two changes to where the flow lands. The created screen now uses the same centred card as the confirm screen, so arriving reads as the other side of the question rather than a different page. The four layout objects both screens share are pulled up next to SECTION rather than copied, so the two cannot drift apart. The class page gains an information alert between its title band and its content: the class has no members, nobody can sign in until the mentor creates their accounts, and an action opens three steps saying how. That blocker is the one thing setup cannot do — nothing on codeclub.org knows who the young people are — and a mentor who does not meet it here meets it in front of a room instead. Neither the alert nor the steps behind it are in the product, and the account-creation screen does not exist anywhere in this repo. The panel says so rather than implying a flow sits behind it; notes.md records both. EducatorClassPage renders its two bands as a fragment with no seam between them, so it is copied in as ClassPageWithBanner with one added prop. Nothing else about it is changed, and nothing shared is touched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What you're trying
One sentence. Which lane, and what approach.
What you believe
The hypothesis from your
meta.ts— what a testing session could disprove.What to look at
A link, once this has a preview or is merged. Add
?full=1&autofill=0if youwant someone to see it the way a tester would.
What you'd like feedback on
The bit you are least sure about is usually the most useful thing to name.
notes.md