Skip to content

Fix handling of click events when anchor has nested elements #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

Fix handling of click events when anchor has nested elements #1246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/components/Tooltip/Tooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,8 +515,10 @@ const Tooltip = ({

const enabledEvents: { event: string; listener: (event?: Event) => void }[] = []

const activeAnchorContainsTarget = (event?: Event): boolean =>
Boolean(event?.target && activeAnchor?.contains(event.target as HTMLElement))
const handleClickOpenTooltipAnchor = (event?: Event) => {
if (show && event?.target === activeAnchor) {
if (show && activeAnchorContainsTarget(event)) {
/**
* ignore clicking the anchor that was used to open the tooltip.
* this avoids conflict with the click close event.
Expand All @@ -526,7 +528,7 @@ const Tooltip = ({
handleShowTooltip(event)
}
const handleClickCloseTooltipAnchor = (event?: Event) => {
if (!show || event?.target !== activeAnchor) {
if (!show || !activeAnchorContainsTarget(event)) {
/**
* ignore clicking the anchor that was NOT used to open the tooltip.
* this avoids closing the tooltip when clicking on a
Expand Down