Skip to content

Commit

Permalink
CI: run codecov even if regression tests fail.
Browse files Browse the repository at this point in the history
Could be helpful to know code coverage even in cases when the 
regression tests are failing - sometimes (hopfully often!) a 
"regression" is an improvement, and a "fail" is thus a success.
  • Loading branch information
rwest committed Jun 8, 2023
1 parent 3c67c3e commit 17cb2ed
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ jobs:

# Regression Testing - Test Execution
- name: Regression Tests - Execution
id: regression
id: regression-execution
timeout-minutes: 60
run: |
for regr_test in aromatics liquid_oxidation nitrogen oxidation sulfur superminimal;
Expand All @@ -141,7 +141,7 @@ jobs:
# Upload Regression Results as Failed if above step failed
- name: Upload Failed Results
if: ${{ failure() && steps.regression.conclusion == 'failure' }}
if: ${{ failure() && steps.regression-execution.conclusion == 'failure' }}
uses: actions/upload-artifact@v3
with:
name: failed regression results ${{ matrix.os }}${{ matrix.libstdcxx-ng }}
Expand Down Expand Up @@ -256,8 +256,9 @@ jobs:
exit 1
fi
# Install and Call codecov only if ALL the tests were successful
# Install and Call codecov only if the tests were successful (permitting failures in the regression comparison tests)
- name: Code coverage install and run
if: success() || ( failure() && steps.regression-execution.conclusion == 'success' )
run: |
mamba install -y -c conda-forge codecov
codecov
Expand Down

0 comments on commit 17cb2ed

Please sign in to comment.