294 rule marginalrule and average energy should check interface names #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests.jl:rule
…s returns nothing (missing node?).
… check for @average_energy calls.
bvdmitri
requested changes
Nov 4, 2025
|
|
||
| q_names, q_types, q_init_block = rule_macro_parse_fn_args(inputs; specname = :marginals, prefix = :q_, proxy = :Marginal) | ||
|
|
||
| fform_type = Core.eval(__module__, fformtype) |
Member
There was a problem hiding this comment.
Let's not use eval, is very dangerous especially when macro generating the code (you have eval inside of eval). Is using the fuppertype (defined above) not sufficient?
Member
There was a problem hiding this comment.
I also think that the tests are failing exactly because of the eval, since it evaluates inside the ReactiveMP, but the structure in tests is defined outside of ReactiveMP
Member
There was a problem hiding this comment.
We should also add a test, that actually checks that the error is being thrown by defining a rule with wrong interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: #294
I would like to get a first review on the code.
The code now checks for misnamed interfaces, including extra interfaces etc (see issue).
Potential things to do:
basic test_rule macro invokationtest intest_rules.jlis breaking due to specification of a node that is unknown when the rule for that node is being called