chore: remove dev feature flag from new application onboarding#1153
Open
MayankBansal12 wants to merge 3 commits intodevelopfrom
Open
chore: remove dev feature flag from new application onboarding#1153MayankBansal12 wants to merge 3 commits intodevelopfrom
MayankBansal12 wants to merge 3 commits intodevelopfrom
Conversation
Summary by CodeRabbit
WalkthroughThis PR systematically removes the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/integration/components/new-signup/input-test.js`:
- Around line 98-115: The test title is inconsistent with its assertion: update
the test name string in tests/integration/components/new-signup/input-test.js so
it matches the expected button text ("Submit") when currentStep is 'role' (or
alternatively change the asserted text to "Next" if that is the intended
behavior); locate the test that sets currentStep: 'role' and references
NEW_SIGNUP_STEPS and the <NewSignup::Input> render, and rename the test
description from "button should have text Next if the current step is role" to
"button should have text Submit if the current step is role" (or adjust the
assert.dom(...).hasText(...) to 'Next' if you prefer that behavior).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: f3d94434-f672-4eb4-a12b-61a30935ab32
📒 Files selected for processing (13)
app/components/application/detail-header.jsapp/components/join-steps/status-card.jsapp/components/new-signup/input.hbsapp/constants/apis.jsapp/controllers/new-signup.jsapp/routes/applications.jsapp/routes/applications/detail.jsapp/templates/join.hbsapp/templates/new-signup.hbstests/integration/components/new-signup/input-test.jstests/integration/components/status-card-test.jstests/unit/controllers/new-signup-test.jstests/unit/routes/applications-test.js
💤 Files with no reviewable changes (5)
- app/routes/applications/detail.js
- tests/unit/routes/applications-test.js
- app/components/application/detail-header.js
- app/routes/applications.js
- tests/integration/components/status-card-test.js
Comment on lines
+98
to
115
| test('button should have text Next if the current step is role', async function (assert) { | ||
| assert.expect(2); | ||
| this.setProperties({ | ||
| onClick: function () { | ||
| this.currentStep = NEW_SIGNUP_STEPS[5]; | ||
| }, | ||
| currentStep: 'lastName', | ||
| isDevMode: true, | ||
| currentStep: 'role', | ||
| }); | ||
|
|
||
| await render(hbs` | ||
| <NewSignup::Input | ||
| @onClick={{this.onClick}} | ||
| @onClick={{this.onClick}} | ||
| @currentStep={{this.currentStep}} | ||
| @dev={{this.isDevMode}} | ||
| />`); | ||
|
|
||
| assert.dom('[data-test-button="signup"]').exists(); | ||
| assert.dom('[data-test-button="signup"]').hasText('Next'); | ||
| assert.dom('[data-test-button="signup"]').hasText('Submit'); | ||
| }); |
There was a problem hiding this comment.
Test name contradicts the assertion.
The test is named "button should have text Next if the current step is role" but the assertion at line 114 expects the button to have text "Submit". The test name should be updated to match the actual expected behavior.
📝 Proposed fix
- test('button should have text Next if the current step is role', async function (assert) {
+ test('button should have text Submit if the current step is role', async function (assert) {📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| test('button should have text Next if the current step is role', async function (assert) { | |
| assert.expect(2); | |
| this.setProperties({ | |
| onClick: function () { | |
| this.currentStep = NEW_SIGNUP_STEPS[5]; | |
| }, | |
| currentStep: 'lastName', | |
| isDevMode: true, | |
| currentStep: 'role', | |
| }); | |
| await render(hbs` | |
| <NewSignup::Input | |
| @onClick={{this.onClick}} | |
| @onClick={{this.onClick}} | |
| @currentStep={{this.currentStep}} | |
| @dev={{this.isDevMode}} | |
| />`); | |
| assert.dom('[data-test-button="signup"]').exists(); | |
| assert.dom('[data-test-button="signup"]').hasText('Next'); | |
| assert.dom('[data-test-button="signup"]').hasText('Submit'); | |
| }); | |
| test('button should have text Submit if the current step is role', async function (assert) { | |
| assert.expect(2); | |
| this.setProperties({ | |
| onClick: function () { | |
| this.currentStep = NEW_SIGNUP_STEPS[5]; | |
| }, | |
| currentStep: 'role', | |
| }); | |
| await render(hbs` | |
| <NewSignup::Input | |
| `@onClick`={{this.onClick}} | |
| `@currentStep`={{this.currentStep}} | |
| />`); | |
| assert.dom('[data-test-button="signup"]').exists(); | |
| assert.dom('[data-test-button="signup"]').hasText('Submit'); | |
| }); |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@tests/integration/components/new-signup/input-test.js` around lines 98 - 115,
The test title is inconsistent with its assertion: update the test name string
in tests/integration/components/new-signup/input-test.js so it matches the
expected button text ("Submit") when currentStep is 'role' (or alternatively
change the asserted text to "Next" if that is the intended behavior); locate the
test that sets currentStep: 'role' and references NEW_SIGNUP_STEPS and the
<NewSignup::Input> render, and rename the test description from "button should
have text Next if the current step is role" to "button should have text Submit
if the current step is role" (or adjust the assert.dom(...).hasText(...) to
'Next' if you prefer that behavior).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Date: 10-03-26
Developer Name: @MayankBansal12
Issue Ticket Number:-
Description:
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Tested in staging?
Add relevant Screenshot below ( e.g test coverage etc. )