Fix regex escape in lexer; export OrderedMap - #18
Merged
Conversation
NirBarak-RecoLabs
force-pushed
the
fix/regex-escape-and-export-orderedmap
branch
from
July 22, 2026 14:09
d9aa6cb to
607ba45
Compare
RecoLabs-YaronBratspiess
previously approved these changes
Jul 22, 2026
NirBarak-RecoLabs
removed the request for review
from MickeyShnaiderman-RecoLabs
July 22, 2026 14:17
MickeyShnaiderman-RecoLabs
previously approved these changes
Jul 22, 2026
NirBarak-RecoLabs
dismissed stale reviews from MickeyShnaiderman-RecoLabs and RecoLabs-YaronBratspiess
via
July 22, 2026 17:13
231c543
NirBarak-RecoLabs
force-pushed
the
fix/regex-escape-and-export-orderedmap
branch
from
July 22, 2026 17:13
607ba45 to
231c543
Compare
MickeyShnaiderman-RecoLabs
approved these changes
Jul 22, 2026
Depth tracking for ()[]{} treated \( as nesting, so patterns like
/\(?/ never closed (S0302). Only unescaped brackets affect depth;
character classes use inClass; depth is floored at 0; escaped \) / \}
outside a class still reduce depth so asymmetric patterns like
/a\[b]/ and /(a\)/ still terminate.
Re-export the type and constructors so callers can type-assert Eval object results without importing internal/. Fixes #17
Version bump for the regex lexer and OrderedMap export release.
NirBarak-RecoLabs
force-pushed
the
fix/regex-escape-and-export-orderedmap
branch
from
July 22, 2026 17:23
231c543 to
7e4a525
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
()[]{}when tracking regex nesting depth (fixesS0302on patterns like/\(?/). Also handles asymmetric escapes (/a\[b]/,/\(a)/,/(a\)/) via character-class state + depth floor.OrderedMap(+ constructors) from packagegnataso Eval object results are type-assertable without importinginternal/(Fixes Reading evaluator.OrderedMap #17).gnata-js0.2.2→0.2.3for the release tag.Test plan
v*after merge to publish npm via workflow