Implement query parameters for Krist endpoints#13
Merged
bananasov merged 4 commits intoReconnectedCC:mainfrom Jul 31, 2025
Merged
Implement query parameters for Krist endpoints#13bananasov merged 4 commits intoReconnectedCC:mainfrom
bananasov merged 4 commits intoReconnectedCC:mainfrom
Conversation
Added new struct field and an SQL WHERE clause to filter out mined transactions in relevant endpoints. Partially closes ReconnectedCC#9.
Added a struct defining the query parameters for the krist
/addresses/{address} endpoint and implemented a DB query similar to the
one used in the address lookup API. Should close ReconnectedCC#9.
I forgot to remove an info trace I was using during debugging and should not have been committed.
bananasov
reviewed
Jul 31, 2025
Genuinely not sure why I made these if statements in the first place lmao
bananasov
reviewed
Jul 31, 2025
Collaborator
bananasov
left a comment
bananasov
left a comment
There was a problem hiding this comment.
all looks good, I'll go over it again on pc
Member
|
Ran the full hoppscotch testing thing I wrote, works perfectly LGTM |
bananasov
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small changes to add query parameters to
/transactions/latestand/addresses/<address>as mentioned in #9. I tested as well as I could on my machine and believe that this should close the issue, but let me know if this needs fixes. I checked and had no conflicts merging #11 with these added changes so there shouldn't be any issues there.