Add new CNV 4.23 deployments and xfail known product bugs

[albarker-rh]

What this PR does / why we need it:

Adds virt-template-apiserver, virt-template-controller, virt-network-resources-injector deployments to hardcoded list
Xfails virt-template-apiserver and virt-template-controller for missing priorityClassName and required-scc (http://redhat.atlassian.net/browse/CNV-94717)
Xfails virt-network-resources-injector since it uses upstream sriov-dp-admission-controller image (https://redhat.atlassian.net/browse/CNV-92888)

Which issue(s) this PR fixes:

Failures in 4.23-iuo-ocs #9

Special notes for reviewer:

jira-ticket:

https://redhat.atlassian.net/browse/CNV-94344

[coderabbitai]

Warning

Review limit reached

@rnetser, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3a880e59-814b-49c6-92de-96ef50eb4556

📥 Commits

Reviewing files that changed from the base of the PR and between 2c27af5 and 41e8c52.

📒 Files selected for processing (3)

• tests/install_upgrade_operators/conftest.py
• tests/install_upgrade_operators/deployment/test_hco_deployment_params.py
• tests/install_upgrade_operators/pod_validation/test_pod_spec.py

📝 Walkthrough

Walkthrough

The change adds three Virt deployment constants, expands SR-IOV Conforma xfail handling to the Virt Network Resources Injector, and adds CNV-94717-based xfail handling for Virt Template deployment checks.

Changes

Operator xfail coverage

Layer / File(s)	Summary
Virt component constants utilities/constants/components.py	Adds constants for the Virt Template API server, Virt Template controller, and Virt Network Resources Injector. Includes them in ALL_CNV_DEPLOYMENTS.
SR-IOV Conforma xfail fixture tests/install_upgrade_operators/conftest.py, tests/install_upgrade_operators/deployment/test_hco_deployment_params.py, tests/install_upgrade_operators/pod_validation/test_pod_spec.py	Renames and broadens the fixture to cover HCO Operator and Virt Network Resources Injector deployments or pods. Adds component-specific xfail messages and updates test usage.
CNV-94717 deployment validation tests/install_upgrade_operators/deployment/test_hco_deployment_params.py, tests/install_upgrade_operators/security/scc/test_cnv_deployment_required_scc.py	Adds the jira_94717_open fixture. Priority-class and SCC annotation checks conditionally xfail for affected Virt Template deployments while CNV-94717 is open.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• RedHatQE/openshift-virtualization-tests#4880: Updates install/upgrade operator fixtures and Jira-based deployment priority-class xfails.
• RedHatQE/openshift-virtualization-tests#5740: Modifies the SR-IOV Conforma xfail fixture for HCO deployments.
• RedHatQE/openshift-virtualization-tests#5839: Overlaps in the install/upgrade operator test and fixture files.

Suggested reviewers: geetikakay, vsibirsk, rnetser

🚥 Pre-merge checks | ✅ 6

✅ Passed checks (6 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Pr Template Sections	✅ Passed	The current PR body contains all four required headings, and the first section has meaningful content: “Adds missing template deployments to hardcoded list.”
Stp Link Required	✅ Passed	The PR adds no test files and no new test functions; all changed test functions existed in the base commit and were only modified.
Stp Scenario Coverage	✅ Passed	PASS: The PR changes three tests, but none contains an STP:, Jira:, or RFE: URL in a module, class, or test docstring; only Polarion markers are present.
Title check	✅ Passed	The title is 57 characters and clearly describes adding CNV deployments and xfails for known product bugs.

✨ Finishing Touches 💡 1

⚔️ Resolve merge conflicts 💡

• Resolve merge conflict in branch 4.23-add-cnv-deployments

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[albarker-rh]

/build-and-push-container

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.89%. Comparing base (a2dc143) to head (2d50858).
⚠️ Report is 312 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5850      +/-   ##
==========================================
+ Coverage   98.67%   98.89%   +0.22%     
==========================================
  Files          25       42      +17     
  Lines        2487     2632     +145     
==========================================
+ Hits         2454     2603     +149     
+ Misses         33       29       -4     

Flag	Coverage Δ
utilities	98.89% <100.00%> (+0.22%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-virtualization-qe-bot-5]

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

• Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
• Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
• Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
• Branch Labeling: Branch-specific labels are applied to track the target branch
• Auto-verification: Auto-verified users have their PRs automatically marked as verified
• Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

• /wip - Mark PR as work in progress (adds WIP: prefix to title)
• /wip cancel - Remove work in progress status
• /hold - Block PR merging (PR author or approvers)
• /hold cancel - Unblock PR merging (PR author or approvers)
• /verified - Mark PR as verified
• /verified cancel - Remove verification status
• /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
• /regenerate-welcome - Regenerate this welcome message
• /security-override - Set security check runs to pass (maintainers only)
• /security-override cancel - Re-run security checks

Review & Approval

• /lgtm - Approve changes (looks good to me)
• /approve - Approve PR (approvers only)
• /assign-reviewers - Assign reviewers based on OWNERS file
• /assign-reviewer @username - Assign specific reviewer
• /check-can-merge - Check if PR meets merge requirements

Testing & Validation

• /retest tox - Run Python test suite with tox
• /retest build-container - Rebuild and test container image
• /retest verify-bugs-are-open - verify-bugs-are-open
• /retest all - Run all available tests

Container Operations

• /build-and-push-container - Build and push container image (tagged with PR number)
  • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

• /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
  • Multiple branches: /cherry-pick branch1 branch2 branch3
• /cherry-pick-retry <branch> - Retry a failed cherry-pick (merged PRs only)

Branch Management

• /rebase - Rebase this PR branch onto its base branch

Label Management

• /<label-name> - Add a label to the PR
• /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

1. Approval: /approve from at least one approver
2. LGTM Count: Minimum 2 /lgtm from reviewers
3. Status Checks: All required status checks must pass
4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
5. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

• dshchedr
• myakove
• rnetser
• vsibirsk

Reviewers:

• RoniKishner
• dshchedr
• geetikakay
• rnetser
• vsibirsk

Available Labels

• hold
• verified
• wip
• lgtm
• approve

AI Features

• Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6-1m)

Security Checks

• Suspicious Path Detection: Monitors paths: .claude/, .vscode/, .cursor/, .devcontainer/, .pi/, .github/workflows/, .github/actions/
• Committer Identity Check: Verifies last committer matches PR author
• Mandatory: Security checks block merge (use /security-override to bypass — maintainers only)

💡 Tips

• WIP Status: Use /wip when your PR is not ready for review
• Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
• Cherry-picking: Cherry-pick labels are processed when the PR is merged
• Container Builds: Container images are automatically tagged with the PR number
• Permission Levels: Some commands require approver permissions
• Auto-verified Users: Certain users have automatic verification and merge privileges

📌 Additional Information

Custom Commands:

• /test-plan — Triggers CodeRabbit to analyze the PR's changed files and post a test execution plan
• /rerun-smoke — Adds retest-smoke label on the PR to trigger smoke tests execution

For more information, please refer to the project documentation or contact the maintainers.

[openshift-virtualization-qe-bot]

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5850 published

[rnetser]

/approve

[rnetser]

/approve cancel

[albarker-rh]

/retest tox

[albarker-rh]

/build-and-push-container

[albarker-rh]

/retest all

[openshift-virtualization-qe-bot-4]

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5850 published

[albarker-rh]

/retest all

[rnetser]

@coderabbitai review

[coderabbitai]

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[rnetser]

@coderabbitai review

[coderabbitai]

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[rnetser]

@coderabbitai review

[openshift-virtualization-qe-bot-3]

/retest all

Auto-triggered: Files in this PR were modified by merged PR #5975.

Overlapping files

tests/install_upgrade_operators/conftest.py