Skip to content

CherryPicked: [cnv-4.20] net, tests, hot-plug: Avoid redundant VMI interface lookup - #5957

Open
cnv-tests-github-webhook-dollierp[bot] wants to merge 1 commit into
cnv-4.20from
CherryPicked-avoid_redundant_iface_lookup-ACivJ
Open

CherryPicked: [cnv-4.20] net, tests, hot-plug: Avoid redundant VMI interface lookup#5957
cnv-tests-github-webhook-dollierp[bot] wants to merge 1 commit into
cnv-4.20from
CherryPicked-avoid_redundant_iface_lookup-ACivJ

Conversation

@cnv-tests-github-webhook-dollierp

@cnv-tests-github-webhook-dollierp cnv-tests-github-webhook-dollierp Bot commented Aug 10, 2026

Copy link
Copy Markdown

Cherry-pick from main branch, original PR: #5578, PR owner: yossisegev

@Anatw RedHatQE
net, tests, hot-plug: Avoid redundant VMI interface lookup (#5578)
fe55f2c 
hot_plug_interface() already returns the full interface status including
interfaceName. Pass it through to set_secondary_static_ip_address()
instead of re-querying VMI status for the same value.

This PR replaces
#5419,
which required fixes, but its original author is away and I cannot push
to their fork (in order to apply these fixes).

Assisted-by: Claude <noreply@anthropic.com>
Assisted-by: Yossi Segev <ysegev@redhat.com>

https://redhat.atlassian.net/browse/CNV-88390

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

* **Bug Fixes**
* Improved hot-plug network behavior when assigning secondary static IP
addresses, ensuring the address is applied to the correct guest
interface.
* Strengthened IP verification to confirm the assigned address on the
intended interface.
* **Tests**
* Updated hot-plug networking tests and fixtures to pass full interface
details into the secondary static IP workflow, aligning with the
corrected behavior.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Anat Wax <awax@redhat.com>
Merged
@openshift-virtualization-qe-bot-5

openshift-virtualization-qe-bot-5 commented Aug 10, 2026

Copy link
Copy Markdown

⚠️ This cherry-pick had conflicts resolved by AI (claude/claude-opus-4-6-1m)

@yossisegev — AI automatically resolved merge conflicts for this cherry-pick. Please review the changes carefully and verify correctness before merging.

@openshift-virtualization-qe-bot-3

openshift-virtualization-qe-bot-3 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

  • Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
  • Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
  • Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
  • Branch Labeling: Branch-specific labels are applied to track the target branch
  • Auto-verification: Auto-verified users have their PRs automatically marked as verified
  • Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

  • /wip - Mark PR as work in progress (adds WIP: prefix to title)
  • /wip cancel - Remove work in progress status
  • /hold - Block PR merging (PR author or approvers)
  • /hold cancel - Unblock PR merging (PR author or approvers)
  • /verified - Mark PR as verified
  • /verified cancel - Remove verification status
  • /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
  • /regenerate-welcome - Regenerate this welcome message
  • /security-override - Set security check runs to pass (maintainers only)
  • /security-override cancel - Re-run security checks

Review & Approval

  • /lgtm - Approve changes (looks good to me)
  • /approve - Approve PR (approvers only)
  • /assign-reviewers - Assign reviewers based on OWNERS file
  • /assign-reviewer @username - Assign specific reviewer
  • /check-can-merge - Check if PR meets merge requirements

Testing & Validation

  • /retest tox - Run Python test suite with tox
  • /retest build-container - Rebuild and test container image
  • /retest verify-bugs-are-open - verify-bugs-are-open
  • /retest all - Run all available tests

Container Operations

  • /build-and-push-container - Build and push container image (tagged with PR number)
    • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

  • /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
    • Multiple branches: /cherry-pick branch1 branch2 branch3
  • /cherry-pick-retry <branch> - Retry a failed cherry-pick (merged PRs only)

Branch Management

  • /rebase - Rebase this PR branch onto its base branch

Label Management

  • /<label-name> - Add a label to the PR
  • /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

  1. Approval: /approve from at least one approver
  2. LGTM Count: Minimum 2 /lgtm from reviewers
  3. Status Checks: All required status checks must pass
  4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
  5. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

  • EdDev

Reviewers:

  • Anatw
  • EdDev
  • azhivovk
  • frenzyfriday
  • nirdothan
  • orelmisan
  • servolkov
  • yossisegev
Available Labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
AI Features
  • Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6-1m)
Security Checks
  • Suspicious Path Detection: Monitors paths: .claude/, .vscode/, .cursor/, .devcontainer/, .pi/, .github/workflows/, .github/actions/
  • Committer Identity Check: Verifies last committer matches PR author
  • Mandatory: Security checks block merge (use /security-override to bypass — maintainers only)

💡 Tips

  • WIP Status: Use /wip when your PR is not ready for review
  • Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
  • Cherry-picking: Cherry-pick labels are processed when the PR is merged
  • Container Builds: Container images are automatically tagged with the PR number
  • Permission Levels: Some commands require approver permissions
  • Auto-verified Users: Certain users have automatic verification and merge privileges

📌 Additional Information

Custom Commands:

  • /test-plan — Triggers CodeRabbit to analyze the PR's changed files and post a test execution plan
  • /rerun-smoke — Adds retest-smoke label on the PR to trigger smoke tests execution

For more information, please refer to the project documentation or contact the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yossisegev yossisegev Awaiting requested review from yossisegev
@Anatw Anatw Awaiting requested review from Anatw
@azhivovk azhivovk Awaiting requested review from azhivovk
@orelmisan orelmisan Awaiting requested review from orelmisan
@servolkov servolkov Awaiting requested review from servolkov
@nirdothan nirdothan Awaiting requested review from nirdothan
@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday
@EdDev EdDev Awaiting requested review from EdDev

Assignees

@yossisegev yossisegev

@cnv-tests-github-webhook-dollierp cnv-tests-github-webhook-dollierp[bot]

Labels

ai-resolved-conflicts branch-cnv-4.20 CherryPicked-from-main needs-rebase sig-network size/S tox:verify-tc-requirement-polarion:passed D/S Testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-virtualization-qe-bot-5 @openshift-virtualization-qe-bot-3 @yossisegev @openshift-virtualization-qe-bot @openshift-virtualization-qe-bot-2 @Anatw