Skip to content

CherryPicked: [cnv-4.20] Remove redundant and duplicated by upstream t2 tests - #5962

Open
cnv-tests-github-webhook-dollierp[bot] wants to merge 1 commit into
cnv-4.20from
CherryPicked-remove-t1-duplicate-tests-Pt9MZ
Open

CherryPicked: [cnv-4.20] Remove redundant and duplicated by upstream t2 tests #5962
cnv-tests-github-webhook-dollierp[bot] wants to merge 1 commit into
cnv-4.20from
CherryPicked-remove-t1-duplicate-tests-Pt9MZ

Conversation

@cnv-tests-github-webhook-dollierp

@cnv-tests-github-webhook-dollierp cnv-tests-github-webhook-dollierp Bot commented Aug 11, 2026

Copy link
Copy Markdown

Cherry-pick from main branch, original PR: #5902, PR owner: OhadRevah

@OhadRevah RedHatQE
Remove redundant and duplicated by upstream t2 tests (#5902)
35cc240 
Remove tests that validate the same behavior already covered by upstream
HCO func-tests (t1), per T2 package evaluation.

strict_reconciliation/test_hco_cr_defaults_on_stanza_deletion.py:
  Remove test_certconfig_defaults_on_stanza_delete (CNV-6377-6393)
and test_livemigrationconfig_defaults_on_stanza_delete (CNV-6403-6417).
  Duplicated by defaults_test.go certConfig (L32-65) and
  liveMigrationConfig (L102-133):

https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/tests/func-tests/defaults_test.go#L32-L133
  Keep test_featuregates_defaults_on_stanza_delete (CNV-6397, CNV-6399).

strict_reconciliation/test_operator_defaults.py:
  Remove entire file — static reads of default values against
  hardcoded constants, covered by defaults_test.go.

launcher_updates/test_default_launcher_updates.py:
  Remove static default value reads (CNV-6911, CNV-6912),
  covered by defaults_test.go workloadUpdateStrategy (L194-228):

https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/tests/func-tests/defaults_test.go#L194-L228

product_uninstall/test_remove_kubevirt.py:
  Remove test_validate_default_uninstall_strategy (CNV-3738),
  covered by defaults_test.go uninstallStrategy (L216-245):

https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/tests/func-tests/defaults_test.go#L216-L245

Remove dead expected_certconfig_stanza and unused imports from
strict_reconciliation/utils.py.

assisted by: claude code claude-opus-4-6

<!-- full-ticket-url needs to be provided. This would add a link to the
pull request to the jira and close it when the pull request is merged
If the task is not tracked by a Jira ticket, just write "NONE".
-->

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

- **Tests**
- Removed outdated validation coverage for default workload update and
uninstall strategies.
- Removed strict-reconciliation tests covering operator defaults,
certificate settings, feature gates, and live-migration configuration.
- Removed unused test fixtures and helper utilities related to deleted
scenarios.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Ohad Revah <orevah@redhat.com>
@openshift-virtualization-qe-bot-3

openshift-virtualization-qe-bot-3 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

  • Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
  • Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
  • Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
  • Branch Labeling: Branch-specific labels are applied to track the target branch
  • Auto-verification: Auto-verified users have their PRs automatically marked as verified
  • Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

  • /wip - Mark PR as work in progress (adds WIP: prefix to title)
  • /wip cancel - Remove work in progress status
  • /hold - Block PR merging (PR author or approvers)
  • /hold cancel - Unblock PR merging (PR author or approvers)
  • /verified - Mark PR as verified
  • /verified cancel - Remove verification status
  • /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
  • /regenerate-welcome - Regenerate this welcome message
  • /security-override - Set security check runs to pass (maintainers only)
  • /security-override cancel - Re-run security checks

Review & Approval

  • /lgtm - Approve changes (looks good to me)
  • /approve - Approve PR (approvers only)
  • /assign-reviewers - Assign reviewers based on OWNERS file
  • /assign-reviewer @username - Assign specific reviewer
  • /check-can-merge - Check if PR meets merge requirements

Testing & Validation

  • /retest tox - Run Python test suite with tox
  • /retest build-container - Rebuild and test container image
  • /retest verify-bugs-are-open - verify-bugs-are-open
  • /retest all - Run all available tests

Container Operations

  • /build-and-push-container - Build and push container image (tagged with PR number)
    • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

  • /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
    • Multiple branches: /cherry-pick branch1 branch2 branch3
  • /cherry-pick-retry <branch> - Retry a failed cherry-pick (merged PRs only)

Branch Management

  • /rebase - Rebase this PR branch onto its base branch

Label Management

  • /<label-name> - Add a label to the PR
  • /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

  1. Approval: /approve from at least one approver
  2. LGTM Count: Minimum 2 /lgtm from reviewers
  3. Status Checks: All required status checks must pass
  4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
  5. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

  • dshchedr
  • myakove
  • rnetser
  • vsibirsk

Reviewers:

  • OhadRevah
  • RoniKishner
  • albarker-rh
  • dshchedr
  • hmeir
  • rlobillo
  • rnetser
  • vsibirsk
Available Labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
AI Features
  • Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6-1m)
Security Checks
  • Suspicious Path Detection: Monitors paths: .claude/, .vscode/, .cursor/, .devcontainer/, .pi/, .github/workflows/, .github/actions/
  • Committer Identity Check: Verifies last committer matches PR author
  • Mandatory: Security checks block merge (use /security-override to bypass — maintainers only)

💡 Tips

  • WIP Status: Use /wip when your PR is not ready for review
  • Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
  • Cherry-picking: Cherry-pick labels are processed when the PR is merged
  • Container Builds: Container images are automatically tagged with the PR number
  • Permission Levels: Some commands require approver permissions
  • Auto-verified Users: Certain users have automatic verification and merge privileges

📌 Additional Information

Custom Commands:

  • /test-plan — Triggers CodeRabbit to analyze the PR's changed files and post a test execution plan
  • /rerun-smoke — Adds retest-smoke label on the PR to trigger smoke tests execution

For more information, please refer to the project documentation or contact the maintainers.

Merged
@openshift-virtualization-qe-bot-2

openshift-virtualization-qe-bot-2 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

⚠️ This cherry-pick had conflicts resolved by AI (claude/claude-opus-4-6-1m)

@OhadRevah — AI automatically resolved merge conflicts for this cherry-pick. Please review the changes carefully and verify correctness before merging.

@OhadRevah

OhadRevah commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

/verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OhadRevah OhadRevah Awaiting requested review from OhadRevah
@hmeir hmeir Awaiting requested review from hmeir
@dshchedr dshchedr Awaiting requested review from dshchedr
@vsibirsk vsibirsk Awaiting requested review from vsibirsk
@rnetser rnetser Awaiting requested review from rnetser
@RoniKishner RoniKishner Awaiting requested review from RoniKishner
@albarker-rh albarker-rh Awaiting requested review from albarker-rh
@rlobillo rlobillo Awaiting requested review from rlobillo

Assignees

@OhadRevah OhadRevah

@cnv-tests-github-webhook-dollierp cnv-tests-github-webhook-dollierp[bot]

Labels

ai-resolved-conflicts branch-cnv-4.20 CherryPicked-from-main needs-rebase sig-iuo size/XXL tox:verify-tc-requirement-polarion:passed D/S Testing verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-virtualization-qe-bot-3 @openshift-virtualization-qe-bot-2 @OhadRevah @openshift-virtualization-qe-bot @openshift-virtualization-qe-bot-4