CherryPicked: [cnv-4.22] [Storage] Refactor golden_image tests to use Fedora DataSource - #5977
Open
cnv-tests-github-webhook-dollierp[bot] wants to merge 1 commit into
Conversation
This PR removes the remaining artifactory usage from the golden images.
The artifactory usage was indirect in utilities/storage.py -> `def
data_volume where it constructed url =
f"{get_test_artifact_server_url()}{image}" if source == "http" else None
`
New fixture golden_image_dv_from_fedora_datasource_scope_module uses
source_ref (DataSource) instead of url (artifactory).
Unused golden_image_data_volume_scope_module was removed.
Based on
#5160
<!-- full-ticket-url needs to be provided. This would add a link to the
pull request to the jira and close it when the pull request is merged
If the task is not tracked by a Jira ticket, just write "NONE".
-->
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
* **Tests**
* Updated golden image permission and listing coverage to use a shared
Fedora-based image data source.
* Removed obsolete RHEL-specific test configuration.
* Retained validation that regular users cannot delete or clone
restricted data volumes and can list permitted volumes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Signed-off-by: Emanuele Prella <eprella@redhat.com>
Contributor
|
@ema-aka-young — AI automatically resolved merge conflicts for this cherry-pick. Please review the changes carefully and verify correctness before merging. |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Branch Management
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
📌 Additional InformationCustom Commands:
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot
added
the
tox:verify-tc-requirement-polarion:running
openshift-virtualization-qe-bot-4
requested review from
Ahmad-Hafe,
acinko-rh,
dalia-frank,
dshchedr and
rnetser
August 12, 2026 09:49
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:passed
openshift-virtualization-qe-bot-4
requested review from
RoniKishner,
josemacassan and
vsibirsk
August 12, 2026 09:50
|
/build-and-push-container |
Contributor
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5977 published |
|
Verification failed for PR #5977. Execution details |
Contributor
|
Failed verification because I used the wrong verification command |
|
/build-and-push-container |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-5977 published |
Contributor
|
/approve |
|
/verified All tests passed for PR #5977. Execution details |
hmeir
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from
mainbranch, original PR: #5922, PR owner: ema-aka-young