CherryPicked: [cnv-4.22] [Storage/Network] Specify architecture for internal HTTP server for multiarch clusters - #5980
Open
cnv-tests-github-webhook-dollierp[bot] wants to merge 1 commit into
Conversation
…ultiarch clusters (#5813) On multi-arch clusters with a single `--cpu-arch` target, the internal HTTP server pod could be scheduled on a node with the wrong architecture. This PR: - Adds a `nodeSelector` with `kubernetes.io/arch` to the internal HTTP server Deployment so it lands on the correct architecture node. - Extracts the duplicated `py_config["cpu_arch"] + cluster_type == MULTIARCH` check (repeated in `utilities/storage.py`, `tests/storage/conftest.py`, and `libs/vm/factory.py`) into a single `get_multiarch_cpu_arch()` function in `utilities/architecture.py`. Failures on multi-arch clusters that run wit single requested arch. <!-- full-ticket-url needs to be provided. This would add a link to the pull request to the jira and close it when the pull request is merged If the task is not tracked by a Jira ticket, just write "NONE". --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> * **Bug Fixes** * Improved multi-architecture cluster handling when creating virtual machines and storage resources. * Registry-based storage volumes now receive the appropriate CPU architecture metadata. * Storage deployments are scheduled onto compatible nodes when architecture information is available. * Improved consistency in default CPU architecture detection across deployment workflows. * Enhanced handling for environments where architecture information is unavailable or not applicable. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Jenia Peimer <jpeimer@redhat.com>
|
@jpeimer — AI automatically resolved merge conflicts for this cherry-pick. Please review the changes carefully and verify correctness before merging. |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Branch Management
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
📌 Additional InformationCustom Commands:
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot-5
requested review from
Anatw,
acinko-rh and
orelmisan
August 12, 2026 10:40
openshift-virtualization-qe-bot-5
requested review from
dalia-frank,
dshchedr,
geetikakay,
josemacassan,
kshvaika,
nirdothan,
rnetser,
vsibirsk and
yossisegev
August 12, 2026 10:41
openshift-virtualization-qe-bot-5
requested review from
Ahmad-Hafe,
EdDev,
RoniKishner,
azhivovk,
ema-aka-young,
kgoldbla and
servolkov
August 12, 2026 10:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from
mainbranch, original PR: #5813, PR owner: jpeimer