Skip to content

[SVS] Add Tiered SVS index implementation #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

rfsaliev
Copy link
Collaborator

@rfsaliev rfsaliev commented Apr 4, 2025

Implemented Tiered version of Scalable Vector Search index (TieredSVSIndex)

  • Vectors moved to backend in 1 background job as a bulk
  • Add basic unit tests for SVS tiered index
  • Add Python binding for SVS Tiered index
  • Backend index synchronized for deleted vectors

Main objects this PR modified

  1. New class TieredSVSIndex
  2. Tiered factory modified to support TieredSVSIndex
  • This PR introduces API changes
  • This PR introduces serialization changes

TODO:

  • Uncomment and fix unit tests copy-pasted from HNSW-tiered or remove if not relevant.

@rfsaliev rfsaliev requested review from meiravgri and alonre24 April 4, 2025 16:19
@rfsaliev rfsaliev force-pushed the rfsaliev/scalable-vector-search-tiered branch from c0064a4 to 267fac6 Compare April 15, 2025 15:03
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 95.76988% with 25 lines in your changes missing coverage. Please review.

Project coverage is 96.50%. Comparing base (ed35da4) to head (5e94154).

Files with missing lines Patch % Lines
src/VecSim/index_factories/tiered_factory.cpp 78.87% 15 Missing ⚠️
src/VecSim/index_factories/svs_factory.cpp 81.48% 5 Missing ⚠️
src/VecSim/algorithms/svs/svs_tiered.h 98.89% 4 Missing ⚠️
src/VecSim/algorithms/svs/svs_utils.h 98.63% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
+ Coverage   96.33%   96.50%   +0.16%     
==========================================
  Files         112      113       +1     
  Lines        6225     6785     +560     
==========================================
+ Hits         5997     6548     +551     
- Misses        228      237       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rfsaliev rfsaliev force-pushed the rfsaliev/scalable-vector-search-tiered branch from 91ca7ee to 1ef36ea Compare April 28, 2025 13:05
@rfsaliev rfsaliev force-pushed the rfsaliev/scalable-vector-search-tiered branch from f0c8b0c to c0314c3 Compare April 29, 2025 08:45
@rfsaliev rfsaliev force-pushed the rfsaliev/scalable-vector-search-tiered branch from a7834da to 4aa73f9 Compare April 30, 2025 14:47
@rfsaliev rfsaliev force-pushed the rfsaliev/scalable-vector-search-tiered branch 2 times, most recently from cd36989 to 5e94154 Compare April 30, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant