fix: include encrypted value in create --secret payload#84
Merged
Conversation
When using `reforge create --secret`, the encrypted value was missing from the API payload. The `mapConfigValueToDto` function wasn't handling the `value` property returned by `makeConfidentialValue`. Changes: - Extract `mapConfigValueToDto` to shared utility (config-value-dto.ts) - Add handling for `configValue.value` (used by encrypted values) - Update both create.ts and set-default.ts to use shared utility - Add payload validation in create test mock for encrypted values - Add `set-default --secret` to interactive menu for consistency - Bump version to 0.0.14 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reforge create --secretnot including the encrypted value in the API payloadmapConfigValueToDtoto shared utility to prevent similar bugsset-default --secretto interactive menu for consistencyProblem
When using
reforge create --secret, the POST payload was missing thevaluefield:{ "value": { "type": "string", "confidential": true, "decryptWith": "reforge.secrets.encryption.key" } }The
valuefield containing the encrypted string was not being included.Solution
makeConfidentialValuereturns{value: encrypted, confidential, decryptWith}mapConfigValueToDtowasn't checking forconfigValue.valuecreateandset-defaultuse the same code pathTest plan
reforge create test.secret --type=string --value=test --secret🤖 Generated with Claude Code