Skip to content

Don't filter Core methods from newly-inferred list #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: v1.10.2+RAI
Choose a base branch
from
Draft

Don't filter Core methods from newly-inferred list #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dc2b5a
Don't filter `Core` methods from newly-inferred list
topolarity May 22, 2025
16d06e4
RAI: `CodeInstance` has no field `owner`
kpamnany May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions base/compiler/cicache.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ ranges. This struct abstracts over access to this cache.
struct InternalCodeCache end

function setindex!(cache::InternalCodeCache, ci::CodeInstance, mi::MethodInstance)
m = mi.def
if isa(m, Method)
ccall(:jl_push_newly_inferred, Cvoid, (Any,), ci)
end
ccall(:jl_mi_cache_insert, Cvoid, (Any, Any), mi, ci)
return cache
end
Expand Down
1 change: 0 additions & 1 deletion test/precompile.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1812,7 +1812,6 @@ precompile_test_harness("Issue #50538") do load_path
@test !isdefined(I50538, :undefglobal)
end


empty!(Base.DEPOT_PATH)
append!(Base.DEPOT_PATH, original_depot_path)
empty!(Base.LOAD_PATH)
Expand Down