Skip to content

Correct make invocation - #163

Merged
jwillemsen merged 1 commit into
RemedyIT:masterfrom
jwillemsen:jwi-brix11make
Sep 9, 2025
Merged

Correct make invocation#163
jwillemsen merged 1 commit into
RemedyIT:masterfrom
jwillemsen:jwi-brix11make

Conversation

@jwillemsen

@jwillemsen jwillemsen commented Sep 9, 2025

Copy link
Copy Markdown
Member
* .github/workflows/ciaox11.yml:
* .github/workflows/taox11.yml:

Summary by CodeRabbit

  • Chores
    • Updated continuous integration workflows to standardize build target specification across platforms (Linux and Windows), simplifying configuration and removing redundant parameters.
    • Enhances consistency and maintainability of automated builds, with unchanged targets and test steps.
    • No impact on product functionality or public APIs; end users see no behavioral changes.

    * .github/workflows/ciaox11.yml:
    * .github/workflows/taox11.yml:
@coderabbitai

coderabbitai Bot commented Sep 9, 2025

Copy link
Copy Markdown

Walkthrough

Replaced brix11 make invocations in two GitHub Actions workflows by removing the -d directory flag and passing paths directly to -N. Adjusted -L usages accordingly. No targets or steps added/removed; only argument formatting changed. Linux and Windows steps updated; no public interfaces changed.

Changes

Cohort / File(s) Summary of Changes
Workflow: brix11 make flag updates
.github/workflows/ciaox11.yml, .github/workflows/taox11.yml
Updated brix11 make commands to drop -d and supply paths directly after -N; removed -d before -L. Linux and Windows variants in taox11.yml adjusted similarly. No target set changes; only argument structure reformatted.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly captures the primary update—correcting the make invocation—in the GitHub Actions workflows, directly reflecting the main change without extra detail.
Description Check ✅ Passed The description lists the specific workflow files modified by this pull request, which aligns with the actual changes to .github/workflows/ciaox11.yml and .github/workflows/taox11.yml and is directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Poem

I twitch my nose at flags that stray,
Hop-hop, I tidy CI’s way—
Drop the -d, let -N lead,
Streams of paths now run with speed.
Carrots aligned, builds in tune,
Thump-thump—green checks rising soon! 🥕✨

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ef01cec and e3e852b.

📒 Files selected for processing (2)
  • .github/workflows/ciaox11.yml (1 hunks)
  • .github/workflows/taox11.yml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: ubuntu-22.04 g++-11 ruby-3.1
  • GitHub Check: ubuntu-22.04 g++-10 ruby-2.7
  • GitHub Check: ubuntu-22.04 g++-11 ruby-3.0
  • GitHub Check: windows-2025 ruby-3.1 vs2022 --release
  • GitHub Check: ubuntu-22.04 g++-11 ruby-2.7
  • GitHub Check: ubuntu-22.04 g++-11 ruby-3.1
  • GitHub Check: ubuntu-22.04 g++-11 ruby-3.2
  • GitHub Check: ubuntu-22.04 g++-11 ruby-2.6
  • GitHub Check: ubuntu-22.04-jruby-9.4.13.0-jacorb-3.9-jdk-8
  • GitHub Check: ubuntu-22.04 g++-11 ruby-2.5
  • GitHub Check: ubuntu-22.04 g++-12 ruby-3.3
🔇 Additional comments (3)
.github/workflows/ciaox11.yml (1)

145-145: Ensure -N is followed by its root argument or drop it when using -L
The -N flags before each -L have no path argument and will cause brix11 to treat -L as the -N value. Either:

  • Supply the root to each -N, e.g.
    … -- make -N $CIAOX11_ROOT -L $CIAOX11_ROOT=$CIAOX11_ROOT/bin/ciaox11_tests.lst …
  • Or drop -N entirely before -L <root>=<list> if -L already implies the root.
    Confirm brix11’s CLI semantics to pick the correct form.
.github/workflows/taox11.yml (2)

133-133: LGTM: Correct -N <path> usage on Linux.


209-209: LGTM: Correct -N <path> usage on Windows (cmd).

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jwillemsen
jwillemsen merged commit f7afc91 into RemedyIT:master Sep 9, 2025
18 checks passed
@jwillemsen
jwillemsen deleted the jwi-brix11make branch September 9, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant