Skip to content

fix: print ready-for-review comment on all ready PRs, not just draft->ready PRs#9

Merged
MantisClone merged 1 commit intomainfrom
print-ready-for-review-comment-always
Mar 22, 2025
Merged

fix: print ready-for-review comment on all ready PRs, not just draft->ready PRs#9
MantisClone merged 1 commit intomainfrom
print-ready-for-review-comment-always

Conversation

@MantisClone
Copy link
Copy Markdown
Member

@MantisClone MantisClone commented Mar 22, 2025

Changes

  1. Added a new output variable type_ready to track whether the PR is in a ready-for-review state
  2. Updated the Determine event type step to check if a PR was opened in a non-draft state (github.event.pull_request.draft == false)
  3. Modified the condition for the ready-for-review-comment job to also run when:
    A PR is opened (event_type == 'opened') AND
    • The PR is not a draft (type_ready == 'true')
    • This will ensure that the ready-for-review comment is posted both when:
  • A PR transitions from draft to ready state (via the "ready_for_review" event)
  • A PR is created directly in the ready state (via the "opened" event with draft=false)
    The first_pr_comment will still run for first-time contributors regardless of whether the PR is in draft state or ready for review.

@MantisClone MantisClone merged commit 46b6d14 into main Mar 22, 2025
1 check passed
@MantisClone MantisClone deleted the print-ready-for-review-comment-always branch March 22, 2025 05:13
@MantisClone MantisClone linked an issue Mar 22, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Develop a reusable Github Actions workflow for posting comments on pull requests

1 participant