Align Android paywall preview mocks with web/dashboard catalog#3633
Draft
JayShortway wants to merge 1 commit into
Draft
Align Android paywall preview mocks with web/dashboard catalog#3633JayShortway wants to merge 1 commit into
JayShortway wants to merge 1 commit into
Conversation
The validation-screenshot preview parser used Android-specific prices and an inconsistent set of trial/intro offers, so the rendering-validation screenshots showed different products/prices/offers than the web and dashboard renders. Update the preview product table to the canonical web/dashboard prices and periods (weekly $2.99 … annual $69.99, lifetime $119.99), give every subscription the same single $1.99 / 1-week introductory offer, and use 'Pro Access' as the store product name to match the web/dashboard tables. This is preview-only data used by Compose @Preview and the Paparazzi validation recorder; no purchasing logic changes. Co-authored-by: joop <joop@revenuecat.com>
Generated by 🚫 Danger |
📸 Snapshot Test126 modified, 467 unchanged
🛸 Powered by Emerge Tools |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
One of four coordinated PRs (iOS, Android, web SDK, dashboard) to reconcile the products/prices/offers shown on the cross-platform paywall rendering-validation screenshots. Each platform mocks the product data missing from the shared
offerings.json/packages.json(which have no prices or offers) from its own hard-coded table, so the screenshots diverged. Android used its own price tiers and an inconsistent mix of free trials / intro prices across packages.Description
Updates
PreviewOfferingParser(the preview-only parser used for@Previews and the Paparazzi validation recorder) to match the web + dashboard preview variable tables, which are identical and are treated as the source of truth (they can't be changed without touching production dashboard code):"Pro Access"as the store productname, matching the web/dashboardproduct.store_product_name.This only changes preview/sample data; no purchasing logic is affected.
Known residual: the
relative_discountbadge is a hard-coded "19%" string on web/dashboard but computed from prices on the SDKs, so that percentage may still differ.Testing
I could not run the Paparazzi recorder or detekt in this environment (heavy Gradle/network setup). Please regenerate the Android validation screenshots via
recordPaparazziBc8Debug/ therecord-and-push-paywall-template-screenshotsjob in CI and confirm.Note: this also changes Android Studio
@Previewsample prices for V2 paywall templates, since the same parser feeds those previews.pr:other+pr:RevenueCatUI+feat:Paywalls_V2labels on review.