Skip to content

Fix workflow prefetch asset contention#3649

Draft
vegaro wants to merge 3 commits into
mainfrom
cesar/workflow-prefetch-asset-contention
Draft

Fix workflow prefetch asset contention#3649
vegaro wants to merge 3 commits into
mainfrom
cesar/workflow-prefetch-asset-contention

Conversation

@vegaro

@vegaro vegaro commented Jun 25, 2026

Copy link
Copy Markdown
Member

Checklist

  • If applicable, unit tests
  • If applicable, create follow-up issues for purchases-ios and hybrids

Motivation

Workflow and offering asset pre-downloads could compete with delivery-critical workflow fetches and resolution work, delaying prefetched workflow availability.

Description

This defers offering and workflow asset pre-downloads until after workflow delivery settles, returns prefetched workflow data so assets can be warmed afterward, and gives workflow CDN fetching and workflow resolution separate dedicated dispatchers. It also clarifies AGENTS.md so agent-opened PRs default to the pr:other label unless the user explicitly requests another primary label. Tested with ./gradlew :purchases:compileDefaultsBc8DebugKotlin and ./gradlew :purchases:testDefaultsBc8DebugUnitTest --tests "com.revenuecat.purchases.common.offerings.OfferingsManagerTest" --tests "com.revenuecat.purchases.common.workflows.WorkflowManagerTest".

vegaro and others added 3 commits June 24, 2026 17:51
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@vegaro vegaro added the pr:fix A bug fix label Jun 25, 2026
@vegaro vegaro changed the title [codex] Fix workflow prefetch asset contention Fix workflow prefetch asset contention Jun 25, 2026
@vegaro vegaro added pr:other and removed pr:fix A bug fix labels Jun 25, 2026
@vegaro vegaro force-pushed the cesar/workflow-prefetch-asset-contention branch from 63b25d9 to f6d3ec3 Compare June 25, 2026 13:27
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.33%. Comparing base (240522e) to head (f6d3ec3).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...otlin/com/revenuecat/purchases/PurchasesFactory.kt 66.66% 2 Missing ⚠️
...ecat/purchases/common/workflows/WorkflowManager.kt 90.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3649      +/-   ##
==========================================
+ Coverage   80.29%   80.33%   +0.03%     
==========================================
  Files         380      380              
  Lines       15593    15606      +13     
  Branches     2181     2183       +2     
==========================================
+ Hits        12521    12537      +16     
+ Misses       2203     2200       -3     
  Partials      869      869              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant