This repository was archived by the owner on Dec 1, 2023. It is now read-only.
WIP: event signature validation #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SachinMeier
changed the title
leishman
reviewed
Jan 17, 2023
|
|
||
| :crypto.hash(:sha256, serialized_event) | ||
| serialized_event | ||
| |> Bitcoinex.Utils.sha256() |
There was a problem hiding this comment.
I thought it would be simpler to have Bitcoinex handle all the crypto-related functions. Should we switch it back?
|
We'll need to update the factory module used by tests to generate test events once the actual signature validation logic is added |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Schnorr signature validation using bitcoinex library.