Skip to content
This repository was archived by the owner on Apr 15, 2025. It is now read-only.

fix(generator): write using utf-8#1004

Draft
AmaseCocoa wants to merge 4 commits into
RobertCraigie:mainfrom
AmaseCocoa:write-using-utf-8
Draft

fix(generator): write using utf-8#1004
AmaseCocoa wants to merge 4 commits into
RobertCraigie:mainfrom
AmaseCocoa:write-using-utf-8

Conversation

@AmaseCocoa

Copy link
Copy Markdown

Change Summary

Changed to explicitly use utf-8 in packaged_schema.write_text to avoid UnicodeEncodeError that cp932 may cause in Japanese Windows environment.

Unit Test is currently under construction :)

Checklist

  • Unit tests for the changes exist
  • Tests pass without significant drop in coverage
  • Documentation reflects changes where applicable
  • Test snapshots have been updated if applicable

Agreement

By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.

@AmaseCocoa

AmaseCocoa commented Aug 10, 2024

Copy link
Copy Markdown
Author

For some reason it seems to contain commit for pull request #1002 :( I forgot that I committed to main by mistake, it seems it has already been Revert.

@AmaseCocoa

Copy link
Copy Markdown
Author

@RobertCraigie Sorry, is there already a test related to prisma.generator.Generate?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant