[FIX]: Fix Share Issues Bug #132
Open
+11
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @samad-yar-khan Can you please review these changes this is the but I mentioned in the public channel |
Contributor
|
@VipinDevelops context.getInteractionData() shouldnt always return general, is this a bug in the Apps Engine ? |
Contributor
Author
Yes @samad-yar-khan ,most probably. It's something to do with app engine, that's why I it took me some time fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
#131
Description
It seems like the
context.getInteractionData()always gives the general room as that is why we were facing weird issues in the code and a lot of features of our app are not working in channels other than general.Acceptance Criteria fulfillment
Proposed changes (including videos or screenshots)
Screencast.from.2024-02-28.00-06-23.webm