[NEW] Extract urls from room description and make them clickable #2249
Conversation
|
@bizzbyster Would you have time to take a look? Thank you 😊 |
|
@water2015sit, good, but actually it should be text "realtime contribution leaderboard" with url https://gsoc.rocket.chat It's Makrdown like in GitHub. |
|
@water2015sit Are you going to update this PR (taking in consideration the comment above from @Adizbek)? |
|
@filipedelimabrito Yes, I will update this PR. |
|
Thanks @water2015sit! |
philipbrito
changed the title
| for (clickablePart in clickablePartList) { | ||
| val clickableSpan = object : ClickableSpan() { | ||
| override fun onClick(widget: View) { | ||
| val intent = Intent(Intent.ACTION_VIEW, Uri.parse(clickablePart)) |
There was a problem hiding this comment.
val intent is not being used here.
philipbrito
left a comment
philipbrito
left a comment
There was a problem hiding this comment.
@water2015sit It is not working properly. Just get a description where the rocket.chat word appears, it is being highlighted but it is not possible to open that supposed link we have there.
Something like [site name](site url) is not working too.
Can you fix it?
|
@filipedelimabrito OK, I will fix it. |
|
@water2015sit Are you able to fix it? |
3 participants
@RocketChat/android
Changes:
Extract urls from room description.
Make urls clickable.
Screenshots or GIF for the change:
IMG_2585.MOV.zip