Skip to content

refactor: remove unnecessary computation invalidation in route change…#36460

Draft
ggazzo wants to merge 2 commits into
developfrom
fix/invalidate-subscribeToRouteChange
Draft

refactor: remove unnecessary computation invalidation in route change…#36460
ggazzo wants to merge 2 commits into
developfrom
fix/invalidate-subscribeToRouteChange

Conversation

@ggazzo
Copy link
Copy Markdown
Member

@ggazzo ggazzo commented Jul 17, 2025

… subscription

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot Bot commented Jul 17, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR has conflicts, please resolve them before merging
  • This PR is missing the 'stat: QA assured' label
  • This PR is not mergeable
  • This PR is targeting the wrong base branch. It should target 8.5.0, but it targets 8.4.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 17, 2025

⚠️ No Changeset found

Latest commit: c4fa1f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 17, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36460/

Built to branch gh-pages at 2025-08-07 01:49 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.07%. Comparing base (be7ceaa) to head (c4fa1f5).
⚠️ Report is 1441 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36460      +/-   ##
===========================================
- Coverage    65.65%   63.07%   -2.58%     
===========================================
  Files         3197     2644     -553     
  Lines       106812    98246    -8566     
  Branches     20332    17985    -2347     
===========================================
- Hits         70130    61972    -8158     
- Misses       34035    34284     +249     
+ Partials      2647     1990     -657     
Flag Coverage Δ
e2e 45.44% <ø> (-11.52%) ⬇️
unit 71.24% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo modified the milestones: 8.4.0, 8.5.0 Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant