-
-
Notifications
You must be signed in to change notification settings - Fork 208
ENH: Parachute Inflation Modeling #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@ArthurJWH please rebase your branch to develop so we can properly review this PR. I'm under the impression the 26 commits of this PR should not belong to this git history |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the parachute model by adding geometric parametrization to represent parachutes as hemispheroids with radius, height, and porosity properties. The key changes include:
- Added
radius,height, andporosityparameters to theParachuteclass with corresponding added-mass coefficient calculation - Updated the flight simulation's parachute dynamics to include inflation modeling and added-mass calculation based on geometric properties
- Extended
StochasticParachuteto support randomization of the new geometric parameters - Updated test assertions to reflect the changes in physics calculations
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rocketpy/rocket/parachute.py | Adds radius, height, porosity attributes and calculates added-mass coefficient from porosity |
| rocketpy/rocket/rocket.py | Updates add_parachute method to accept new geometric parameters |
| rocketpy/simulation/flight.py | Implements inflation modeling and added-mass calculation using parachute geometry; updates parachute callbacks |
| rocketpy/stochastic/stochastic_parachute.py | Extends stochastic model to support randomization of radius, height, and porosity |
| tests/unit/test_utilities.py | Updates safety factor assertion to match new physics calculations |
| tests/unit/test_flight.py | Updates aerodynamic forces test values to reflect changed dynamics |
| docs/user/rocket/rocket_usage.rst | Adds example usage of new parachute parameters |
| docs/user/first_simulation.rst | Adds example usage of new parachute parameters |
| README.md | Adds example usage of new parachute parameters |
| CHANGELOG.md | Documents the enhancement |
e02aceb to
8cef755
Compare
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
When triggered, the parachute is modeled as fully opened
New behavior
The parachute inflation will be simulated using a volumetric flow model with simple inviscid flow
Breaking change