Skip to content

Conversation

@ArthurJWH
Copy link
Contributor

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

When triggered, the parachute is modeled as fully opened

New behavior

The parachute inflation will be simulated using a volumetric flow model with simple inviscid flow

Breaking change

  • Yes
  • No

@ArthurJWH ArthurJWH requested a review from a team as a code owner November 1, 2025 01:10
@ArthurJWH ArthurJWH self-assigned this Nov 1, 2025
@Gui-FernandesBR
Copy link
Member

@ArthurJWH please rebase your branch to develop so we can properly review this PR. I'm under the impression the 26 commits of this PR should not belong to this git history

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the parachute model by adding geometric parametrization to represent parachutes as hemispheroids with radius, height, and porosity properties. The key changes include:

  • Added radius, height, and porosity parameters to the Parachute class with corresponding added-mass coefficient calculation
  • Updated the flight simulation's parachute dynamics to include inflation modeling and added-mass calculation based on geometric properties
  • Extended StochasticParachute to support randomization of the new geometric parameters
  • Updated test assertions to reflect the changes in physics calculations

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
rocketpy/rocket/parachute.py Adds radius, height, porosity attributes and calculates added-mass coefficient from porosity
rocketpy/rocket/rocket.py Updates add_parachute method to accept new geometric parameters
rocketpy/simulation/flight.py Implements inflation modeling and added-mass calculation using parachute geometry; updates parachute callbacks
rocketpy/stochastic/stochastic_parachute.py Extends stochastic model to support randomization of radius, height, and porosity
tests/unit/test_utilities.py Updates safety factor assertion to match new physics calculations
tests/unit/test_flight.py Updates aerodynamic forces test values to reflect changed dynamics
docs/user/rocket/rocket_usage.rst Adds example usage of new parachute parameters
docs/user/first_simulation.rst Adds example usage of new parachute parameters
README.md Adds example usage of new parachute parameters
CHANGELOG.md Documents the enhancement

@ArthurJWH ArthurJWH force-pushed the enh/parachute-inflation-modeling branch from e02aceb to 8cef755 Compare November 10, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants