Skip to content

Conversation

@aixgeek
Copy link

@aixgeek aixgeek commented Nov 8, 2025

image

Important

Fixes GeminiHandler to use custom base URL for token counting if googleGeminiBaseUrl is set.

  • Behavior:
    • Fixes issue with GeminiHandler not using custom base URL for token counting.
    • Adds httpOptions with baseUrl in countTokens() if googleGeminiBaseUrl is set.
  • Misc:
    • No changes to other methods or files.

This description was created by Ellipsis for d2c9937. You can customize this summary. It will automatically update as commits are pushed.

@aixgeek aixgeek requested review from cte, jr and mrubens as code owners November 8, 2025 06:54
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Nov 8, 2025
@roomote
Copy link

roomote bot commented Nov 8, 2025

Rooviewer Clock   See task on Roo Cloud

Review complete. The change properly fixes the issue where countTokens() was not using the custom base URL. The implementation is consistent with other methods (createMessage() and completePrompt()) and follows the established pattern in the codebase.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants