Fix: Disable Gemini reasoning during context condensing #9911
+22
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #9867.
Problem
When using Gemini Flash with reasoning enabled, API errors occur after context condensing operations. The reasoning blocks (thoughtSignature) interfere with the condensing prompt structure.
Solution
This PR disables reasoning features (
enableReasoningEffortandmodelMaxThinkingTokens) specifically for Gemini and Vertex providers during context condensing operations, while maintaining them for normal conversation flow.Changes
Task.tsto check if the provider is Gemini or Vertex during condensingTesting
Feedback and guidance are welcome!